"Read More" News... - no more news...

[glued2]

Hi Folks, I can't find this answer anywhere so thought I'd ask....  

For about half the news items i add I simply want to add a short text, with no long version at all...  (I'm using round templates) it still says Read More.. though.    

Is there a way to only show the read more link if there is a longer story?
(otherwise thats going on my wish list )  

cheers
Nick.
.

[fienieg]

No there isn't! You can remove the readme link, but that will permantly remove it!

[pcwacht]

I managed to get rid of an unwanted " Read More " link

Logic, test if length of longtext is shorter then 9 characters (sometimes a wysiwyg editor leaves a '< /P>' in place).

Open up /modules/news/view.php AFTER YOU MADE A BACKUP!!!!! You have been warned!

search for:
// Query posts (for this page)

change next line from :
   $query_posts = $database->query("SELECT group_id,post_id,title,link,short,posted_by,posted_when FROM ".TABLE_PREFIX."mod_news_posts WHERE section_id = '$section_id' AND active = '1' AND title != ''$query_extra ORDER BY position DESC".$limit_sql);

to :
   $query_posts = $database->query("SELECT * FROM ".TABLE_PREFIX."mod_news_posts WHERE section_id = '$section_id' AND active = '1' AND title != ''$query_extra ORDER BY position DESC".$limit_sql);


search for:
// Replace vars with values

add a new line after:
$post_long = strlen($post['long']);

replace these lines (lill bit down):

Code:

if(isset($users[$uid]['username']) AND $users[$uid]['username'] != '') {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, $uid, $users[$uid]['username'], $users[$uid]['display_name'], $users[$uid]['email'], $TEXT['READ_MORE']);
} else {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, '', '', '', '', $TEXT['READ_MORE']);
}

to:

Code:

if(isset($users[$uid]['username']) AND $users[$uid]['username'] != '') {
if ($post_long < 9) {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, $uid, $users[$uid]['username'], $users[$uid]['display_name'], $users[$uid]['email'], '');
} else {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, $uid, $users[$uid]['username'], $users[$uid]['display_name'], $users[$uid]['email'], $TEXT['READ_MORE']);
}
} else {
if ($post_long < 9) {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, '', '', '', '', '');
} else {
$values = array(PAGE_TITLE, $group_id, $group_title, $group_image, $display_group, $display_image, stripslashes($post['title']), stripslashes($post['short']), $post_link, $post_date, $post_time, '', '', '', '', $TEXT['READ_MORE']);
}
}

Have fun!

John

[melissa]

Thanks a lot for this. I just came up with the same question.

It's sort of annoying for the "Read More" link to pop up if you haven't even populated the "long" section.

[melissa]

Actually, is there any chance of fixing this up for 2.6? 

I can post the whole file with the change, if it would save time for anyone.

[zaggi]

Please do melissa, that would be nice Thx

[Ryan]

@melissa: If you haven't already done it (sorry I haven't checked), then I suggest posting this to the tracker on the project page (and then us developers won't forget to look at it).

[melissa]

For those who want it, here is the view.php file with the change to "read more".

Ryan, I will add give it my best shot to add to the tracker.

Cheers,

Melissa.

With the attachment, rename to view.php. (Covered in shame from not having used an attachment when I first posted.)

[attachment deleted because of being too old]

[Ryan]

Melissa, I would much prefer if you could either upload an attachment to your post or have a link to view.php, rather than placing all code inside the post (it makes your post unnecessarily long). I am sorry to say it but I don't think this will make it into 2.6

[kibmcz]

Would it be possible to have it so if the "Long:" text box is empty it dosn't put the "Read More" link??

[i2Paq]

Would it be possible to have it so if the "Long:" text box is empty it dosn't put the "Read More" link??

I was under the inpression that it would do this, but it does not. Is there a way that would make this possible?
The reason I aske this is that it then can be used in more the one way. I was planning on using the News module as a sort of web-blog.

[melissa]

Okay Ryan.

I've updated my previous post. 

If it's not going to be possible for 2.6, how about 2.6.1? 

[pcwacht]

I was under the inpression that it would do this, but it does not. Is there a way that would make this possible?

It does just this!

Get the view.php.txt from Melissa, some posts up, rename it to view.php and copy it over the existing one -> /modules/news/view.php
(As allways, backup!!)

The logic it uses:
It test to see if the longtext has a length shorter then 9 characters, if so no read more, if not read more
Why test length ?
Cause the wysiwyg editors tend to leave <p></p> in the fields so a check on empty wouldn't be enough.

It does work.

John

[i2Paq]

@pcwacht, works.

[pcwacht]

@i2Paq, change the style of the postloop, the post title is still a link to long text