GDPics Gallery Module

[ruebenwurzel]

OK guys, here we go.

At the Addons-Repository I have released Version 0.5 of GDPics.

Changelog:
+Added language support
+Added german language file
+minor changes in the layout of the modify windows
+Fixed a lot of code issues
+Replaced all short tags (<?) and Upper Case tags (?PHP) to ?php
+Stored all files unix konform
+Added search table entries to the install script
+deleted GD_search.php and update_gedpics.php
+uninstall script deletes now all tables and the search table entries
+install script now supports mysql5 strict mode

Hope you like it

Matthias

[jschor]

Great work!
One question though: How do we upgrade from older versions?

[ruebenwurzel]

Hello,

sorry forgot to post, was to late yesterday night 

How to Upgrade from previous versions:
- If you use 0.41 only override all existing files with the new one. There are no Database changes.
- If you use versions previous 0.41 an update is not possible at the moment, but will be possible as soon as i have finished the updatescript. (next few days)

Matthias

[moviestar]

For my default icon (include path) it has /modules/gdpics/folder.png everytime I change it to what i want it to be, it updates succesfull but doesn't change the path.
Also the default icon is showing a big red X. When I check the file location, the folder is there, but when I right click on the folder in the gallery the pathstops at my website eg. http//www.website.com.
I can change the a picture in my gallery as the folder icon. That function workd fine, but the default folder icon isnt. can someone help. thank you.

[ruebenwurzel]

Hello,

there was a wrong column name in the tables. Fixed it and released version 0.6 at the Add-ons Repository. Should work now.

Matthias

[HStrunz]

Great works. Thx.

But only when i view the index site my whole design is broken.
The image sites are working. I edited the css but no effect.
I'm using WB 2.6.4, GDPics 0.6 an prosimii_wb as default template.

URL : http://www.suchen-orten-bergen.de
Gallery is under "Photos"

Does someone have an idea for fixing it?

Greets Holger

[ruebenwurzel]

Hello,

know about this. If you have no pictures in the root folder (means only all galleries in subfolders like on your site) the index site breaks the layout. As there are a lot of div containers and a very complicated script fixing this seems not so easy. As i reodered the cod for version 0.6 of this modul i had a short look over this but i didn't find a working solution.

Think we will fix it in the next version. If you try to find a fix, look at the view.php of this modul. There are some tewakings needed. I think some containers should have an if statement so that they are only displayed when pictures in the root of the gallery folder are present.

Matthias

[Stu-Art]

Hi there,
sorry I stopped contributing to GDPics, I had too mcuh work to write any updates

What is the problem?

The code is very messy, I inherited it from the previous coder and never cleaned it up.

Stu...

[ruebenwurzel]

Hello Stu,

i did clean the whole code. Can you have a look at the actually version from the addons repository (http://addons.websitebaker.org).

The problem wich is described is that it is not possible to have all pictures in subfolders of the media/gallery folder. The first gallery has to be in the root, all others coulld be in subfolders. Better seems to be to have the option to have a gallery in the root (+additional subfolders) or only to have them in subfolders.

Hope you understand what i mean.

If you make changes on the modul, please use the latest version from the repository as startpoint.

Thanks

Matthias

[Stu-Art]

This is a strange problem because on my own site I use GDPics with subfolders only and no photos in the root and it works fine.

As I lost my HD sometime ago I didn't have a test environment locally anymore so I justed installed everything new.

• WAMP
• WB 2.6.4
• GDPics 0.6
• # prosimii_wb

and everything seems to work fine in whatever gallery configuration I try i.e.  with only one column, all files in the root, no files only sub-dirs, combination of the above, with picture thumbs without. 

So I think its something the users has modified in the CSS. I do notice they have centered the divs. Also I note that they specify a photo size bigger than their div size so it overflows the available space.

Stu...
PS One day I will rewrite the Divs and CSS, as they are both overly complicated.

[leoedin]

hi

I just checked the addons repository - GDPics isn't there? Whats happened?

[ruebenwurzel]

Hello,

sorry my fault, forget to set it acvtive as i updated it yesterday. Should work now.

Matthias

[Panther]

I'm having an issue with the breadcrumbs...

I keep getting the following error

Home / Fatal error: Using $this when not in object context in /home/.bobbie/rmf_group/rmfgroup.com/modules/gdpics/view.php on line 178

Everywhere but at the main level

If I turn the breadcrumbs off, the pages work fine.

[crossbow]

I get exactly the same problem as Panther.

Turning off breadcrumbs gets around it so I guess thats the way to live with it.

[Waldschwein]

Hi!

Yes, having the same problem, it has something to do with a false using of the $this variable , bit I don't know exactly what's wrong there.
I think it is in the false class, or not defined there, but well - I am no programmer...
The code around line 178 is the following:

Code:

   // Generate breadcrumbs
    if ($display_breadcrumbs=='yes') {
        $split = explode('/', $album);
        echo '<div class="path"><a href="'.$_SERVER['PHP_SELF'].'">'.$GDTEXT['HOME'].'</a> '.$path_sym.' ';
        for ($i = 0; $i < count($split)-1; $i++) {
            echo '<a href="'.$_SERVER['PHP_SELF'].'?album=';
            for ($j=0; $j < $i+1; $j++) {
                echo '' .myurlencode($split[$j]). '/';
            }
            $temp = str_replace($this->string_search,'',$split[$i]); // That's the one -> $this, it's only there declared in the view.php
            echo '">' .$temp. '</a> '.$path_sym.' ';
        }
        echo '</div>';
    }

Well, would be quite cool if someone could fix it. I think GDPics Gallery module is the best for WB (yes, I know, many don't like it). But all others only display somehow (or not) pics, GDPic has the feature most pic modules should have: Comments, showing the name you want, etc. And it's not as feature overblown as others like Gallery or Coppermine.

Regards Michael

[greenlemon]

Hallo,

ich habe ein Problem mit der Ansicht der Thumbübersicht.
Zu sehen hier:
http://zauberwald.styleventure.de/pages/galerie-2.php

der fehler tritt auch nur im firefox auf....

leider habe ich noch keine Möglichkeit gefunden, diese Ansicht
zu ändern. Hat jemand eine Idee?

-----------------------------------

Hi everyone,

i have some problems with the thumbnail-overview viewing by ie.
have a look at:
http://zauberwald.styleventure.de/pages/galerie-2.php


at the moment im trying to fix that problem, but i dont know how.
some ideas to help me?


Danke und Gruß
greeni

[trab9000]

here is how I fixed it:

in view.php, find:

Code:

                echo '</div>';
                if (isset($page_links)) {
                        echo '<div class="page_list">[ '.$page_links.' ]</div>';
                }
                echo '</div>';

and replace it with:

Code:

                //echo '</div>';
                if (isset($page_links)) {
                        echo '</div><div class="page_list">[ '.$page_links.' ]</div>';
                }
                echo '</div>';

That should do the trick.

Bart

[sparkdigital]

HI all,

Love the GD pic mod but I can't seem to be able to add captions to the images. The drop down list where I choose which gallery to set the captions for is always empty.

Any ideas what I might be doing wrong?

Also, the page gallery seems to take awhile to load (up to 20 sec), could this be because of large files in the gallery folder? Is there a guideline as to the maximum size for each image?

I've also noticed that the gallery displays differently in FF / Safari / Opera, I specified three images in a row but in these browsers there are two on the first row, then the third on the second row and this repeats itself.

Any sugestions?

Thanks for your help!

Konrad

[marathoner]

I've also noticed that the gallery displays differently in FF / Safari / Opera, I specified three images in a row but in these browsers there are two on the first row, then the third on the second row and this repeats itself.

GDPics is creating 3 images on a row. They are using a left float which means that the first one is the leftmost, the second is to the right of the first, and the third is to the right of the second...unless there isn't enough room and it's floated down. You'll need to either adjust the width of the container, reduce the size of the  thumbnail, or use CSS to adjust the margin/padding.

[Jaz]

Hi,

I just installed GDPics v0.7 with WB 2.6.7. but it's not creating any thumbnails or resized pics -it only shows the original size photos and white boxes with red crosses for everything else when the pics are in PNG format (PNG support is enabled within the GD v2 installation on my server) so I wasn't sure if this module supports it. If not is there some way to enable PNG support within it as a lot of my pics have been edited by the site owner and saved as PNGs and I don't want to have to go through converting them all to JPG unless absolutely necessary.

I also get the breadcrumbs error so have disabled it for now but wondered if there is a fix for it yet (got a bit confused as to whether some of the code changes above were for that problem or not  )

Any help would be appreciated thanks.

[laurentw]

Hello, I found 2 problems :

- this gallery not supporting accent or ' (éà '  ex.)  on the name of the directory
- if subdirectory, no possibility to navigate back in a top directory.

regards

[nottledim]

I can't add captions either.  It seems that the problem is the use of the mysql UPDATE to change the caption in the mod_gdpics_captions table when the entry doesn't exist.   Not too sure why the entry doesn't exist but it seems to me that it's to do with adding more pictures to the gallery.  When the gallery is first created it creates the caption entries OK but if you add further pictures the caption table entries don't get created so adding captions fails.

I'm using version 0.7 BTW.

Dick

[nottledim]

I can't add captions either.  It seems that the problem is the use of the mysql UPDATE to change the caption in the mod_gdpics_captions table when the entry doesn't exist.   Not too sure why the entry doesn't exist but it seems to me that it's to do with adding more pictures to the gallery.  When the gallery is first created it creates the caption entries OK but if you add further pictures the caption table entries don't get created so adding captions fails.

Well, you can fix the problem by changing save.php in the section where the INSERT query occurs.  There are two such queries, one for albums and one for images.  This is near the bottom of the file. Change  INSERT INTO  to REPLACE INTO.  You'll also want to disable the UPDATE section above it as this is the bit that's wrong.  I bodged that by changing if ($fetch_num[0] != 0)   to  if ($fetch_num[0] == -1)  which it shouldn't ever be.  Better to remove the whole section but I'm not 100% sure this fix works for all situations and bodging makes it easy to revert.  Need to study it more.

Use at your own risk.   A backup of the data base is prob a good idea.

Dick

[nottledim]

[
Well, you can fix the problem by changing save.php in the section where the INSERT query occurs.  There are two such queries, one for albums and one for images.  This is near the bottom of the file. Change  INSERT INTO  to REPLACE INTO.

it doesn't work of course - you get duplicate entries.  To fix that you need to add a UNIQUE key on the image name, but that doesn't work because albums set image name to NULL.  So you need to copy album name to imagename for albums only.  Then it works.

UPDATE mod_gdpics_captions SET imagename=album where isalbum='yes'
ALTER IGNORE TABLE mod_gdpics_captions ADD UNIQUE (imagename)

You also need to change NULL to $key in the "Insert for album caption" section which was changed above to set imagename equal album for album title entries.

Works better but still not really tested it.

If I find it works without problems I'll post a patch sometime later.

DIck

[Stefek]

Hello!

Just installed this module but the thumbs don't seem to be generated.
GD lib is enabled like this:

GD Support     enabled
GD Version    bundled (2.0.28 compatible)
FreeType Support     enabled
FreeType Linkage     with freetype
T1Lib Support    enabled
GIF Read Support    enabled
GIF Create Support    enabled
JPG Support    enabled
PNG Support     enabled
WBMP Support     enabled
XBM Support    enabled

Don't know what's wrong.

Happy for any advices.

Best Regards,
Stefek