GDPics Gallery Module

[Stu-Art]

Hi there,
Well to tell you the true I am stuck with the CSS formatting... and I might convert to using tables for the image and dir lists...once I added support for filenames my lists screwed up and won't line up anymore...and I am wasting large amounts of time trying to fix this!!

I have already made the following changes
* made everything an option, num of dir columns, thumbs dir location, display filenames, definable folder icons but have yet to update the admin module page;
* added support for dirs and images in the root directory;
* have selectable album icons (at the moment I rename an already created thumbnail)
* prevented resizing passed original image size

Things to do:
* Fix CSS or convert to tables
* add support for imagemagick
* update admin module
* look at cache photo option (skidrash's suggestion)
* Look at Exif info (the info is a little strange for my Canon 300D)
* look into templates (I really don't know where to start with this)

One thing I was thinking about was having a separate dir for the thumbs, like in Pickle...the advantage is you don't add thumbs dirs to your exisiting photo libraries...the disadvanatge is when you delete a photo dir the cache doesn't get cleared!!

Stu...

[Stu-Art]

To skidrash and others, I finally fixed the CSS (after discovering the spacer DIV)

I have updated GDPics to 0.38 for testing:
+Added support for Directory and images on first page
+Images can not be resized beyond their original size
+Can show filenames under images
+Moved Image description to same box as Exitf etc info
+Added Caching option for resampled image size only (better image loading time but uses more disk space)
+Thumbnail directory, No of Directory Columns, show filenames, default folder icon defined as variables
+CSS info updated to expand to page size (needs to be updated in your screen.css) and modified to suit your design and number of columns and directories etc
+Added support for different folder icons (for now you can copy thumbnail image to thumbs/album.jpg to test)

For now all options are in the top of View.php. I will start working on the admin module next and a way to select a folder icon and save it as a folder looking icon.

The cache logic became very complicated so there might be bugs...especially the cleanup of the cache, if you change the standard image size.

Stu...
Edited: just updated zip to removed debug echos

[skidrash]

Wow Stu, you've been busy!  Well I tried it out and it's looking pretty good!  I wasn't able to try all the options, like 'thumbs dir' and the 'No of cols' etc, but the images in the root gallery load perfectly and the css looks good too.

I did notice though, when I applied the CSS that the mouse-would underline the folders, but on images is almost looks like a 'strikethrough'.  Like the underline is too high, running behind the image instead of under it.

The number of columns seem to conflict with the the gallery width.  Like if you set the cols to high in the admin, the wrap around of the images starts and stops in odd places.  Is this what you meant when you said the screen.css needs to be "modified to suit your design and number of columns and directories etc"?

I couldn't figure out how to test the caching option for resampled images.  Going by the time it takes them to load from my server, it looks like they are still being resampled on-the-fly.  Is there an option that I had to turn on to test it?

[Stu-Art]

Hi Skidrash,

I really don't like the whole CSS part of GDPics, and will look at alternate solutions soon using templates. Your strikethrough problem is probably related to your CSS settings.

There is some code in the span div to control the width and layout of the thumbnails to stop the problem you are describing and it partially works but you need to do a lot of messing with the num of cols, the thumbnail size and the css.  If you set a big number in the num of cols it basically sizes to your content div/table.

The caching option is called clear_cache and its set to true (in other words no cache).  Set it to false then you will see duplicates in your thumbs dir in the format (screensize_filename) after you view photos.

Stu...
PS I have managed to break the admin module so the update for this may take sometime....I was trying to add some field to the db.
PPS If you send me your website I can look at your css problems.

[skidrash]

Well here is the my test page for gdpics if you want to see it...  http://test.lordgilbane.com/pages/gallery.php

I will try out that caching option as soon as I get a chance.  As for the CSS, if its being to much trouble, is there any reason why you don't want to use html to format it (ie. tables, etc)?

~skidrash

[Zwizzle]

As I read this thread, it feels as if I'm the only one experiencing problems met GDPics (both 0.36, 0.37 and 0.38). I've installed WB 2.6.2 fresh on a local windows server, running Apache 2.0.55, PHP 5.1.2 and MySQL 5.0.19. So far, no real problems - except that I had to use the patch to get it to run with MySQL 5.

When I installed GDPics 0.38, the only feedback I got after installation, was 'Field 'directory' doesn't have a default value'. I figured that didn't sound too bad. When I added a GDPics Gallery page and went to its Admin page, the page displayed incorrectly, displaying the following code

Code:

$value) { $dis_key = str_replace('_', ' ', $key); ?>  query("SELECT * FROM ".TABLE_PREFIX."mod_gdpics_captions WHERE section_id = '$section_id'"); while ($fetch_captions = $query_captions->fetchRow()) { // Album captions. if (isset($captions_list[$fetch_captions['album']]) && $fetch_captions['isalbum'] == 'yes') { $captions_list[$fetch_captions['album']]['caption'] = $fetch_captions['caption']; } // Image captions. if (isset($captions_list[$fetch_captions['album']][$fetch_captions['imagename']])) { $captions_list[$fetch_captions['album']][$fetch_captions['imagename']] = $fetch_captions['caption']; } } foreach ($captions_list as $key => $value) { if ($key == $_POST['album']) { foreach ($value as $image => $caption) { if ($image == 'caption') {?>

in between the top 'Modify page'-bar and the first two options below that ('Give location of gallery' and 'Number of columns'). When I try to fill in some data on the page and click 'save', I get

Code:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'caption']; ?>','yes')' at line 1

because the option 'Description of album:' defaults to '<?=$captions_list[$key]['caption']; ?>'. When I fill in a real string and hit 'save', it says it's saved to page correctly, but when I view it, it says 'Page content not found', even when I move around my image directories.

I've tried rolling back to version 0.37 and 0.36, but to no avail. Only 0.36 gives a shorter error message, but the problems remain.

Anyone knows what the cause (and solution) might be? Thanks!

[ruebenwurzel]

Could you look if all tables are installed?

Look at install.php there you see what tables should be installed.

Matthias

[Zwizzle]

Could you look if all tables are installed?

Look at install.php there you see what tables should be installed.

Matthias

Hi Matthias,

yes, tables are all there. Database-wise, everyting seems ok. I've re-installed WB without the patch this time, but by forcing MySQL into MySQL4-mode. Still the same problems, although this time a few settings (those on the right) on the GDPics admin page are pre-filled-in this time, and the picture page actually shows some pictures, although in a heavily distorted lay-out. When I click on one of the thumbs (which it has created), I get a empty screen which stays that way.

[Stu-Art]

Hi,
I will look at the problem in the morning as I don't have access to my test environment from home. It sounds like the db is not being updated with the default values. When you installed the module did you use the admin page to enter the default values.  I have noticed you need to save the setting at least once to update the db. I have made a few changes to this in the latest version that I am updating now to make sure there are some default values. I have not tested the module with mysql 5, so there could be some sql syntax changes.

BTW: the page will look screwed up until you import the css styles from the top of the view.php to your screen.css.  Another thing I have fixed. They are now loaded into the gd page, so you don't have to mess with your screen.css (useful for those people with no editing skills).

If you are getting thumbs then check the path in the url and make sure the filename is correct. Also make sure you have a temp/gd_cache and that the rights are 0777. If you click on a thumb then go to the cache dir you should find the cached resampled photo.

Do other pages in your WB work ok?

Stu...

[Zwizzle]

Hi Stu,

for the moment, this is the only mod in WB that's causing me problems, although, as I said, I had to use MYSQL4-mode to get WB up and running correctly in the first place. But apart from that, all seems fine.

Thumbs are created correctly as soon as I access the picture page. I've also repeatedly tried to fill in default values for all settings on the admin page, and they do show up in the database - as far as I can tell.

Zwizzle

[Stu-Art]

Hi Zwizzle,

I don't know what your problem can be without some further info.  I have just downloade the new miniserver with MYSQL 5, so I can test both WB and GDPics with the new versions of PHP and MYSQL.

http://www.uniformserver.com/index.php?us=news

The only field that is essential is the 'Location of gallery' which should be something like /media/gallery/ (trailing / is important).  This is the Field 'Directory' in the table 'mod_gdpics_settings'.  If this is not gettting updated then you have a DB problem. Of course make sure you actually have a directory wb/media/gallery/dirname otherwise it won't work.

Also, as mentioned before, the /wb/temp/gd_cache dir holds the resampled Image, after you click on the thumb. If this is not getting created then no Image will display.

Stu...
PS I am off to England for a long weekend therefore I won't be able to release the new version of GDPics.  Its ready but I need to do some testing with the new admin functions I have added. I am also finishing off the slideshow feature and I want to make more things selectable, so if you want you can just display a photo and nothing else or you get all the info like a photo website!!

[Zwizzle]

Hi Stu,

thanks for the feedback. I've checked again, and yes, it seems as if GD-conversion has no problems: thumbs are created, and the resized images can be found in the temp dir.

As I've tried quite a lot of things, but am not a hard-core PHP hacker, I think I'll give up on GDPics for now, and go with ImageGallery, although it's my second choice, given the amount of pictures I have to index. I'll check back in the future. Thanks again.

Cheers,
Zwizzle

[Zwizzle]

Just to let you know, the problem has been "solved" (or rather, circumvented). First, I reverted to MySQL 4.1.18 (from 5.0.19) and then reinstalled WB (and cleared the existing databases, of course). This didn't work, as it had the same effect with GDPics. I then reverted from PHP 5.1.2 to 4.4.2 (which was the goal from the start, because PHP4 won't work with MySQL5). After again reinstalling WB and mods, it worked. So I figure my problems were PHP5-related.

I'm now happily running my private little website using GDPics.

[Stu-Art]

Great, I will be updating the module in a couple of days, probably early next week as I am away this weekend.

There seems to be a general problem with MYSQL and WB. Something to do with the not having default values entered in the DB, which I will define with this new update.

I have also downloaded a new version of a WAMP and will try out WB with all new versions of PHP and MYSQL and see what happens.

Stu...

PS One of the reasons I started updating GDPics was to view my own gallery.  Unfortunately it doesn't work that well with a lot of directories and files and I have over 37Gbs

[Stu-Art]

Hi all,
Another update for GDPics to 0.39
+Added new options to Admin page and added some more user input error checking
+Fixed problem when first run to not loads whole WB dir structure instead of just /media dir
+New fields added to DB to support new options
+Created upgrade_gdpics to add new DB records for exisiting GDPics users
+Updated the install script for new DB records and set default values for MySQL 5
+Added slideshow code
+Added variables to control all image display options - next, prev, resampled size, filename, exitf, breadcrumbs
+Added additional next/prev links above image
+Enabled CSS code from within View.php (this will take precedence over screen.css), therefore can be used without modifying screen.css

If you have time please test it using the new features.

Note: the code for selecting the folder icon is not working yet 

Stu...

[kweitzel]

OK ... installation goes fine ... but error comes when trying to make a gallery page ...

Code:

Warning: dir(C:\xampp\xampp\htdocs/media/gallery/) [function.dir]: failed to open dir: Invalid argument in C:\xampp\xampp\htdocs\framework\functions.php on line 77

Fatal error: Call to a member function read() on a non-object in C:\xampp\xampp\htdocs\framework\functions.php on line 78

This seems to be still related to the non existing folder "gallery" ... can you create this with a script as well?

cheers

Klaus

[Stu-Art]

thanks Klaus, I have now added it to the install script. I have the folder icon selection working now so I will post an update shortly.

Stu...

[skidrash]

Hey I just tried 0.39 and its looking real good.  The slideshow is excellent.  One question, how can I confirm that the resampled image is being cached?  I enabled "Allow caching of resampled image" but the picture is still really slow to load and I can't seem to find any cached files in the folder.

[mroony]

Very cool.  I didn't have any problems installing, but a little weirdness in a few directories.  But man... sweed module.  Thank you so much.

http://www.mroony.com/pages/bookmarks/gd-pix-test.php

That is a linky to my little test gallery... Only posting because I don't really have time to write down the errors I am having... sorry... its late and my bed is calling my name.


Thank  you again!!!!!!!

[Stu-Art]

The new version is ready but I don't have time to release it, its crazy at work at the moment, I will try to tonight.  The only thing I need to sort out is a strange problem with some of my new admin options not keeping their settings.

I have now added CSS editing in the admin module and you can basically turn every setting on or off, so you can either have a very simple gallery or a very complex photography style gallery. Selecting a folder icon now works.  I also rearranged the admin module and added a help page and fixed a couple of bugs with the original admin module.

I just looked at your pages, the gallery looks good, but I notice the folder icon is not transparent.  You can change the folder icon in the code in version 0.39, its a variable at the top of view.php.  In version 0.40, this is in the admin module.  I also noticed you have a problem with Portage Players' Fantastics, because there is a ' in name. If you remove this it will work. I will try and see if I can wrap the dir names so this will work in future. I am also interested to know what would happen with dirnames with accents!

Stu...

[Stu-Art]

mroony ,
The problem you have with some folders, is that some images are 0 bytes.  Unfortunately the error checking on the return from the GetImageSize is not very good. Something to look at in the next version

Stu...

[Stu-Art]

Hi all,
here is the new release. I had a quick look at the error checking corrupted image files and its too complex, as I would have to write my own PHP error_handling routines. Also there is no support for dir names with ' or " in them.

Update by Stu-Art to 0.40
+Added image display options to DB and Admin pages - next, prev, resampled size, filename, copyright, breadcrumbs
+Updated Install and Upgrade_gdpics to add new DB records
+Gallery directory /media/gallery created during installation
+Added support for different folder icons, selectable from the Admin page and reorganised caption page
+Added CSS editing to Admin page
+Add Help to Admin page
+fixed a problem with displaying non image thumb files in admin page
+Reorganised Admin page so that the modify buttons don't show when modifying sub-screens is open
+Added transparency to folder.png
+fixed path separation spacing
+Added variable for breadcrumbs symbol
+Added some more error checking on file type (but can't catch E-Warning errors generated by getimagesize

Future ideas:
1. Rewrite to support tables for thumbs list - easy to control output and better cross browser support
2. Ability to search captions/filenames
3. Template to control look

Stu...
PS: Use the update script if you already have GDPics installed

[heinzelmann05]

when i want to view a GDPics Gallery it comes following "Warning: ini_set() has been disabled for security reasons"
If it possible to use GDPics without ini_set cause this function is disabled on my php server.
thanks a lot
(excuse my bad english)
EDIT Now i´ve deleted line 35 in view.php and now it go

[kibmcz]

When i try to use your release of GDpics i get these errors when i try to view the output:

Warning: getimagesize(/home/kibmcz/public_htmlmypc.jpg): failed to open stream: No such file or directory in /home/kibmcz/public_html/modules/gdpics/view.php on line 221

Warning: unlink(/home/kibmcz/public_htmlcgi-bin): No such file or directory in /home/kibmcz/public_html/modules/gdpics/view.php on line 392

Here is  a screenshot of the errors:

[Stu-Art]

Hi,

Looks like a problem with the directory you specified for the gallery, as there is no slash between the dir and filename. What did you use?

the default is /wb/media/gallery/. I think I know what you tried to do, you tried to specify a dir outside of wb. I am not sure you can do as the program uses the WB system variable as its base, its how the original module was written.  I can look at this if you want this feature next week.

Regarding ini_set, I don't have the code in front of me now, but I will look on Tuesday.

stu...