Feedback Module

[oeh]

thank you for this hint. So the solution should be to force the parser to encode/decode the cyrillic letters.

Please edit class.parser.php from /modules/feedback and complete the to functions:

Code:

 function encodeSpecialChars(&$value) {
      $value = ereg_replace("ä","ä",$value);
      $value = ereg_replace("Ä","Ä",$value);
      $value = ereg_replace("ö","ö",$value);
      $value = ereg_replace("Ö","Ö",$value);
      $value = ereg_replace("ü","ü",$value);
      $value = ereg_replace("Ü","Ü",$value);
      $value = ereg_replace("ß","ß",$value);
      $value = ereg_replace("€","€",$value);
    return $value;
  }

  function decodeSpecialChars(&$value) {
       $value = ereg_replace("ä","ä",$value);
       $value = ereg_replace("Ä","Ä",$value);
       $value = ereg_replace("ö","ö",$value);
       $value = ereg_replace("Ö","Ö",$value);
       $value = ereg_replace("ü","ü",$value);
       $value = ereg_replace("Ü","Ü",$value);
       $value = ereg_replace("ß","ß",$value);
       $value = ereg_replace("€","€",$value);
    return $value;
  }

in the same manner with the codes oeh has posted.

Regards
Ralf

I've added allot of HTML entities to the class.parser.php
Inn all, it is 578 lines.
Al so I've attached a file with just the HTML entities tabe
for use with other parser files.

Give me a howl, if there are any errors wit the new file

Se attached files.

[ereemst]

Hi, i have smal question..

i use the Portfolio module to show restaurants in the area of Egmond (http:www.egmondonline.nl choose - eten en uitgaan..

And i want to use the feedback module to give the visitors the chance to give there feedback/review about the restaurant of shop

but because the portfolio module gets its info from a details page if you click on  restaurant  and not in the portfilio catalog witch i have a extra section made for feedback it shows al the feedbacks in every restaurant the same.. i was wandering do you have a solution for it...

what i really want is the same as the topic module has.. but i am nog php expert....

gr. Erik

[Ralf (Berlin)]

Hello Erik,

there is no solution for this problem. The Feedback Module is bounded to the id of page, where it is shown and it doesnt care frome where the contents will come.

Regards
Ralf

[Ralf (Berlin)]

Because of a security vulnerability it is highly recommend to upgrade to Feedback Module, Release 0.30!

Download: Feeback Module.

Regards
Ralf

[rimbimbi]

Hallo,

ich hatte im Januar eine ziemlich kritische Sicherheitslücke im Formular Modul (war warscheinlich die die du behoben hast?) gemeldet, aber keinerlei Feedback erhalten. Ich wußte nicht einmal ob ein Ticket erstellt wurde.

Hatte auch einen konkreten Lösungsvorschlag mitgeschickt.

Warum wurde es dann erst jetzt gefixt?

Grüße,
Michael

[kweitzel]

@Michael:

1) hier geht es um das Feedback Modul und nicht das Formularmodul ...
2) Wenn es sich um ein WebsiteBaker Kernmodul (mit ausgeliefert) handelt, kannst Du auch selber sicherstellen, daß ein Ticket geschrieben wird: http://project.websitebaker2.org/newticket ... solange Du da alle Daten (inkl. E-Mail Adresse) eingibst, wird das auch bearbeitet werden. Alle Tickets kannst Du hier einsehen: http://project.websitebaker2.org/report/7

Gruß

Klaus

[rimbimbi]

Ups... wer lesen kann ist klar im Vorteil sorry...

Hatte die Sicherheitslücke hier gemeldet:
http://www.websitebaker2.org/en/community/security-issues/report-a-security-incident.php

Werde ich dann wohl nochmal machen müssen...

[Waldschwein]

Hallo!

Entschuldigung, dass ich hier dazwischen funke:
Das Formular ist eingetroffen vor einiger Zeit und wird auch momentan vom Dev-Team bearbeitet. Ich bin nicht der Meinung, dass man sicherheitsrelevant e Sachen in trac breittreten sollte, das fördert nicht gerade das Vertrauen in die Software. 
Leider haben die Formulare momentan keine "Rückmeldung" (weil ursprünglich nicht vorgesehen), aber das erfordert erstmal etwas Absprache.
Ich bin der Meinung: Bugs gehören in trac, Sicherheitsprobleme nicht. Aber ich bin kein Dev, ich habe nur die Formulare kopiert...

Gruß Michael

[erpe]

Isn't this the english part of the forum?

Maybe a mod can move the post to the german thread.

rgds

erpe

[maya]

hi
I like this model and I want to use it in my hebrew language site, but it replace some chars with non hebrew chars.
(ä  ö etc.) I tried to change the class.parser but it its not working for me.
can I get some help?
Thanks

[Ralf (Berlin)]

I like this model and I want to use it in my hebrew language site, but it replace some chars with non hebrew chars.
(ä  ö etc.) I tried to change the class.parser but it its not working for me.

At the moment the only chance is to mask the chars like in the parser.class.php. There is no better solution available because the parser does not really supports utf8.

Sorry,
Regards
Ralf

[maya]

Hi Ralph

thank. do you know were I can find the right chars so i can find the chars in hebrew to try to fix it it?

[Ralf (Berlin)]

Please have a look here: Hebrew Characters.

Regards
Ralf

[adysnake]

Hi there, tnx for this modul is great.
I have same questions  

1. How to stay always displayed these fields:


2. In to mail sent to admin for approval may be include URL pages were added feedback?

[Ralf (Berlin)]

Hi,

both is not possible with the actual version, Sorry.

Regards
Ralf

[adysnake]

  tnx for reply ... i waiting update 

[Ralf (Berlin)]

I've just released Feedback Module 0.31, this version solve two problems:

• date/time formatting in NL.php
• replacement of deprecated functions in class.parser.php

Download Feedback Module.

Regards
Ralf

[Hans]

Hello Ralf
there is a strange output in the comments. Is it possible to show only the date and time and not the text in the box (attachment) and, of course, how?
WB 2.8.1.

Thanks!
Hans

[Ralf (Berlin)]

Hello Hans,

sorry, I had some free days...

Please edit the language file i.e. NL.php and look for

Code:

define('fb_frontend_comment_header',                 '<a href="mailto:%s">%s</a> schreef op %s:');
define('fb_feedback_datetime', 'd-m-Y \o\m H:i'); 

you may change to:

Code:

define('fb_frontend_comment_header',                 '%3$s:');
define('fb_feedback_datetime', 'd-m-Y \o\m H:i'); 

to show only the date/time.

Please look at PHP Manual - sprintf()  to understand, how to format the strings.

Regards
Ralf

[snark]

Why not just modify the languagefile of the guestbookmodule and use that as feedbackmodule?

With the guestbookmodule you have much more functions

[Hans]

@Ralf,
thanks for helping. I changed the code and everything works fine now
@snoork, I'll give that a try, thanks.
Hans

[D72]

I am trying to use the Feedback module as well.
I made some test entries and i noticed that the feedback comments are visible too in the main blog page.
Can i customize the module so the feedback comments arel only visible when people are reading the long story?

My main blog is:

Code:

www.website.com/blog.php

The feedback comments should be only visible at:

Code:

www.website.com/posts/the-long-story-of-an-article.php

Is this possible?

[lt635]

Hi,

Thank you for a great module.  I am trying out the feedback module on one of my websites that we are just about to go live with. 

I am having some problems removing/changing some of the text in the language file.  PHP is not one of my strengths so I am hoping somebody can assist me here.

Line 131 approx (using Dreamweaver):
Original text:

define('fb_frontend_intro',  'Please tell us and all visitors of <strong>%s</strong> <a href="%s">your opinion about this article</a>.');

This is what I have at the moment: 

define('fb_frontend_intro',  '%s <br /><a href="%s">Click here to give us your feedback</a>.');

How can I remove the %s in red above without breaking the link?  I only want the text to say 'Click here to give us your feedback'.

I appreciate any help with this.

Thanks
Regards
Lene

[dbs]

hi, try this:

Code:

define('fb_frontend_intro',  '<!-- Please tell us and all visitors of <strong>%s</strong> --><a href="%s">Click here to give us your feedback</a>.');

[Ralf (Berlin)]

define('fb_frontend_intro',  '%s <br /><a href="%s">Click here to give us your feedback</a>.');

How can I remove the %s in red above without breaking the link?  I only want the text to say 'Click here to give us your feedback'.

You can tell the Feedback Module to use only the second argument in this way:

Code:

define('fb_frontend_intro','Click <a href="%$2s">here</a> to give us your feedback');

For understanding the sprintf() function and the usage of the arguments please look at the PHP manual.

Regards
Ralf