Code section problem

[lexscripta]

Hi WB gurus!

I am having a little problem with getting the code snippet below to work. I am using a "CODE" section. (WB 2.6.7).  Its function is to grab info from another server and display it on a WB page. Can anyone tell me if the code is correct - I mean are there any glaring problems, as I cannot get it to do its bizness... (the url - xyberlinks.net  - is not the actual url, for privacy issues, however everything else is exactly the same)

Code:

if(!isset($_GET["article"])){
  $_GET["article"] = "";
}
$ch = curl_init();
curl_setopt($ch, CURLOPT_HTTPGET, true);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_ENCODING, "gzip,deflate");
curl_setopt($ch, CURLOPT_URL, "http://xyberlinks.net/links.php?id=13424&incode=1&article=$_GET[article]&g=" . urlencode(serialize($_GET)));
$html = curl_exec($ch);
curl_close($ch);

echo $html;

Any help is greatly appreciated..

LexScripta

[thorn]

Hello,

just two comments:
1. http://en.wikipedia.org/wiki/Cross-site_scripting - ok, you know that, i bet
2. inside double-quotes use {$_GET['article']} instead of $_GET['article']

thorn.

[lexscripta]

WB didn't like your suggestion. It changed it to:

if(!isset()){
  $_GET["article"] = "";
}

Seems the {} aren't appreciated within the standard braces ()

LexScripta

[thorn]

WB didn't like your suggestion. It changed it to:
if(!isset()){
  $_GET["article"] = "";
}

No,no. Inside doublequotes " you have to use {$x['i']} instead of $x['i'].

But see http://projects.websitebaker.org/websitebaker2/ticket/553
So, inside code-section, you have to use {$x['i'] }

Code:

curl_setopt($ch, CURLOPT_URL, "http://xyberlinks.net/links.php?id=13424&incode=1&article={$_GET['article'] }&g=" . urlencode(serialize($_GET)));

should do the trick - supposed your PHP has curl-support compiled in.

Edit: or use

Code:

curl_setopt($ch, CURLOPT_URL, "http://xyberlinks.net/links.php?id=13424&incode=1&article=".$_GET['article']."&g=" . urlencode(serialize($_GET)));

thorn.