Guestbook and searching

[Achrist]

If you add - as I have done - Guestbook section to several pages - then an the way searching is constructed generates erroneus results (way too many). The reason is this. Guestbook enters the following code into the Search table:

SELECT [TP]pages.page_id, [TP]pages.page_title,    [TP]pages.link    FROM [TP]mod_guestbook, [TP]mod_guestbook_setti ngs, [TP]pages WHERE [TP]pages.page_id = [TP]mod_guestbook_setti ngs.page_id AND [TP]mod_guestbook.name

• \'[W][STRING][W]\' .... etc.

It is not clear to me why mod_guestbook_setti ngs is referenced here, and the result is that if there is a search match in one of the mod_guestbook columns, then all pages pointed to by mod_guestbook_setti ngs.page_id are returned as hits. This, of course, is wrong.

I suggest the following code instead (removing mod_guestbook_setti ngs and linking pages and mod_guestbook on page_id instead)

query_start:
SELECT [TP]pages.page_id, [TP]pages.page_title,    [TP]pages.link    FROM [TP]mod_guestbook, [TP]pages WHERE

query_body:
[TP]pages.page_id = [TP]mod_guestbook.page_ id AND [TP]mod_guestbook.name

• \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR

[TP]pages.page_id = [TP]mod_guestbook.page_ id AND [TP]mod_guestbook.email

• \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR

[TP]pages.page_id = [TP]mod_guestbook.page_ id AND [TP]mod_guestbook.homep age

• \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR

[TP]pages.page_id = [TP]mod_guestbook.page_ id AND [TP]mod_guestbook.messa ge

• \'[W][STRING][W]\' AND [TP]pages.searching = \'1\'

This code produces correct search results on my site.

[ruebenwurzel]

Hello,

never tried to have more then one guestbook on my page, so never recognized this issue. Will test your code and if it works integrate in the next version of the guestbook modul. But please if you post in futue code here in the forum use the code formating. This is easier for us to read and prevents for copy and paste issues. So you mean to change th code as following?

Code:

$query_start_code = "SELECT [TP]pages.page_id, [TP]pages.page_title, [TP]pages.link FROM [TP]mod_guestbook, [TP]pages WHERE ";

Code:

$query_body_code = "
    [TP]pages.page_id = [TP]mod_guestbook.page_id AND [TP]mod_guestbook.name [O] \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR
    [TP]pages.page_id = [TP]mod_guestbook.page_id AND [TP]mod_guestbook.email [O] \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR
    [TP]pages.page_id = [TP]mod_guestbook.page_id AND [TP]mod_guestbook.homepage [O] \'[W][STRING][W]\' AND [TP]pages.searching = \'1\' OR
    [TP]pages.page_id = [TP]mod_guestbook.page_id AND [TP]mod_guestbook.message [O] \'[W][STRING][W]\' AND [TP]pages.searching = \'1\'
    ";

Thanks

Matthias

[Achrist]

Thats right, thanks.