FaqBaker 1.4.1 is slightly buggy

[Ploc]

I'm trying the faqbaker module on the last release of WebsiteBaker core in order to check if this module is now utf8 compliant and full compatible with WebsiteBaker core.

Unfortunately, the last release of faqbaker, 1.4.1, is a little buggy. You'll see how I'm trying to create a new category, then a new question with its answer.

1/ Creating a new category :

I create a new category whose name is :

Code:

category with an ' and an é and that's all

Then the admin page displays the category as :

Code:

category with an \' and an é and that\'s all

When I ask the edit page of the category, the category is displayed as :

Code:

category with an ' and an é and that's all

Finally, the faq page on the public website displays the category as :

Code:

category with an \' and an é and that\'s all

I think that there is a missing stripslashes somewhere in the code.

2/ Same test with a question and its answer :

I create a new question whose name and answer are :

Code:

question with an ' and an é and that's all
answer with an ' and an é and that's all

Then the admin page displays the question and the answer as :

Code:

question with an \' and an é ..
admin display answer with an \' and an é and that\'s all ..

When I ask the edit page of the category, the category is displayed as :

Code:

question with an \' and an é and that\'s all
answer with an \' and an é and that\'s all

If I cancel the edition of the question, the faq page on the public website displays the question and the answer as :

Code:

question with an ' and an é and that's all
answer with an \' and an é and that\'s all

If I validate the edition of the question, the faq page on the public website displays the question and the answer as :

Code:

question with an \' and an é and that\'s all
answer with an \\' and an é and that\\'s all

There is also one or two stripslashes missing in the code, and some utf8_decode utf8_encode also...

If anyone is strong enough to fix these bugs, a 1.4.2 release of faqbaker would be greatly appreciated.

Ploc

[Ploc]

Since I had no response to my previous post, I think that this module is not maintained any more.

I needed this module for my personal website so I decided to fix the bug myself. Hopefully I succeeded in fixing it the altough I'm not really skilled in php.

The fix is mainly concerning the way strings are displayed in the public interface, and on the admin interface (when displaying or editing category and questions/answers).

You can find the updated module attached to this post. It has been successfully tested on my personnal website (v2.6.5) and on a test fresh install (v2.6.7).

Have fun !

[DGEC]

Thanks for fixing that for those who use it. I may, one of these days.
Hopefully it will be updated officially.

[Ploc]

This is another release for module FaqBaker.

The 1.4.3 release is now including french language file !

[doc]

Hello ploc,

there are ongoing updates to the FAQ module. The forum member thorn has added some bugfixes for German Umlauts and the display of images. This fixes will make the module utf8 complient. In addition thorn fixed another bug. In some cases, it was possible to add a question without a category with the result, that this question couldn´t be edited or deleted anymore.

Further on, all PHP function calls addslashes and striplslashes were replaced witht the WB functions add_slashes and strip_slashes which take into account magic_quotes_gpc settings in php.ini. This is required to prevent possible SQL injection if magic_quotes are off.

Will forward this message to the forum member thorn, who applied the bugfixes, so we could join your and his version (French + bugfixes).

Some of the developers are in vacation at the moment (Germany), so that could take a while. Once the new version is suffiently tested, it will be released (as v1.5) on the Addons Repository.

Regards Christian

[Ploc]

Great news ! Good job ! No problem for merging my fixes and the ones from Thorn... Maybe for version 1.4.4 or 1.5 (as utf8 is a major enough change) ?

[marccouture]

While coders are working on the module, I would also suggest looking at default style settings as the module does not display properly under Internet Explorer 7.  When the module is installed on a page as the only content section, it leaves a big space on top (see attached screenshot).  I can't find how to fix this, I've tried several different templates and the problem persists.  As usual, this is not a problem with Firefox...

[Ploc]

I think that the problem comes more from the main template than from the faqbaker module template...

Let me show you a working example of faqbaker :

http://lespiedssurterreamap.free.fr/pages/les-pieds-sur-terre/foire-aux-questions.php

I've also tested the module with the standard template, and everything seems to work fine !

[marccouture]

OK, I just noticed some errors in the template .css that caused the problem, it's now fixed.  I should have looked at it longer...  Thanks for the tip!

[Ploc]

Pas de problème ! 

[DssTrainer]

Anyone noticing that dollar signs "$" are being removed from the view with FaqBaker?

I have a question "How much does this cost" and I answer "This costs $800". I see it in the admin area and i even checked the database. But when I view the page in all browsers, I see:
"This costs 00".

It is removing the "$8".. this happens with all characters that follow a $ so I think the PHP is reading it as a variable and replacing it with a null.


Can anyone confirm?

[Ploc]

Yes I do, I tried it just now and the public page displays :

Code:

This costs 0

It doesn't even display the 00 as it does for you.

I think there is another slight bug...

I also find that moving question up and down relative to other questions does not work very well. It often take two times to do it before it is effective...

[doc]

Hello,

thanks to the bug fixes introduced by the forum members ploc and thorn, v1.4.5 of the Faqbaker module is available for testing. The bugs reported in this thread are fixed and the French language file added by ploc is contained.

Please test the new release of the FAQBaker module, before it will be uploaded to the Addons Repository.

Again I would like to thank ploc and thorn for it´s apprecitated contributions to WB.

Regards Christian

Removed attachment and released the latest FAQBaker version on the Addons Repository

[Ploc]

FaqBaker 1.4.5 is ok for me, it is running perfectly.

You can update the addon repository.

[SourDough]

I've been playing around with this module and realized that there wasn't a delete.php file included.  I also noticed that the ordering icons were inconsistent with other modules, i.e. all categories and questions had both up and down arrows appearing, so I made some changes in modify.php.

I've attached my changes.