Media Folder: Automatic Unzip File

[Hilltop]

Hello everyone!  I have modified the Media module of WebsiteBaker 2 to allow the user to upload a single ZIP file which is then automatically unzipped into the upload directory.  This saves a HUGE amount of time when uploading pics to gallery directories, etc... 

I wanted to post my modifications here so that you WB experts could review them and let me know if I did this correctly, or if I left huge security holes open, etc... ( ).  I would really appreciate your feedback on this.

I had to modify the following files:
./admin/media/upload.php
./admin/media/template.php

I am attaching these files here as a ZIP file.
(If the attachment doesn't work, email me and I'll post them on my site.)

[Hilltop]

It appears that a bunch of people have read this post but no comments.  I hope I didn't do something wrong or offend someone.

Just trying to help make WB a better CMS...

Thanks,

Hilltop

[ruebenwurzel]

Hello,

sorry for not answering. Like your idea and will download and test the files. If there are no issues maybe we can add it to WB.

Thanks for your Work

Matthias

[kweitzel]

Personally I must have overseen this ... in gerneral the idea is good ... but the code audit I'll leave to somebody else.

cheers

Klaus

[pcwacht]

Did a brief look at the code

In template.html, line 87 is hardcoded text, best is to put this in the language file.

maybe even move the tick box, create extra unzip lines under the 10 uploadfile spaces to keep persistantie with the layout.
The text pushes down the next lines

upload.php
This looks like a typo to me?
line 105

Code:

if (isset($_FILES['file1']['name']) & isset($_POST['unzip']) )

shoudln't it be:

Code:

if (isset($_FILES['file1']['name']) && isset($_POST['unzip']) )

It looks like you leave the zip after unzipping?
Might be a nice option to ask user if he wants that

Further no strange things detected, it looks good to me security wise.

Did you test this with directories in the zip? Does it recreate a zipped directory structure?


John

[DGEC]

This looks like a great idea. Hope it is able to vetted soon!

[Hilltop]

Thanks so much everyone for your input on this! 

From your suggestions I see that there are still some things to work on, so I'll keep at it.

No, I haven't tested with a ZIP which contains directories.  I will try that a.s.a.p. 

Yes pcwacht, you are right it should be && instead of &.  Sorry!

I have not learned enough about the language files to do this yet, but will keep in mind.

I didn't think it necessary to have multiple boxes supporting the unzip feature, since a single ZIP file can contain all the files which the user desires to upload.  What does everyone think?

Yes, good idea about deleting the ZIP file, but this would add a great deal to the complexity if you have to ask the user each time.  If we automatically deleted the ZIP, that would probably okay, but it's just as easy for the user to click "Delete"...

I wonder how hard it would be to have another button called "Unzip" next to each ZIP file in a directory, that way the user could unzip a file without having to manually upload it at that time.  I might tinker with this soon...


Thanks again everyone and I'll look forward to your comments on this as I fix these issues!

[DGEC]

I like all the ideas actually

Regarding having multiple boxes, it would be nice, but only if you can keep the interface clean. About deletes - maybe have a "unzip and delete file" checkbox?

I found a free file manager with unzip... somewhere... where was that....

Being able to upload the zip and leave it there definitely is nice for recovery if nothing else. As it is, it's a great step forward.

I have a bunch of MP3s and PDF transcripts that I'm going to be uploading soon, so this is perfect. Oh wait. I hope they're not too big.

[erpe]

Hi Hilltrop

any improvements on this module?
It doesn't work with wb 2.7.

Are you still working on this module?

rgds

erpe

[Boudi]

Same question as Erpe,

This mod is exactly what I was looking for! But indeed not working under 2.7.

*bummer* 

[doc]

Hello,

have had a quick look an did some changes to get the automatic unzip function working for WB 2.7.
As I have not had the time to test the fix properly, remember to backup the following files: /admin/media/template.html and /admin/media/upload.php

Tested with a ZIP file without path information, just some files in it. Does only work for the very first file as in the previous version posted by Hilltop.

Regards Christian

P.S.: Once we found a stable solution, it may be an option for WB 2.7.x ...

[Boudi]

Hi Christian,

Thnq for picking this up. I think Hilltrop his idea is a very good one.

I tested your modified version:

- uploaded the 2 files in the admin/media/
- created 1 zip file containing 2 directories (So 1 main directory, 2 sub. The pictures in the 2 subs)
- uploaded it
- Worked like a charm

After this I uploaded another zip file which went successfull too.

I only tested it with .jpg files.

So overall it looks good.

Personally I think this mod suits perfect with the uploader module: http://www.websitebaker2.org/forum/index.php/topic,9087.msg71570.html#msg71570.

Thnq again for taking the time to get it work for now.

Greetz
Boudi