Manual Module

[pcwacht]

Nope doesn't have a clue

Didn't wrote this module, just debugged a bug

John

[kweitzel]

I am not good enough to debug them myself (but will be getting there), just good enough to post them 

cheers

Klaus

[kweitzel]

ahh ... and another thing, if somebody works on this module:

Is it possible to include more than 1 pagelevel?

Like:

1. Chapter1
  1.1 Subchapter1
    1.1.1 Sub-Subchapter1
    1.1.2 Sub-Subchapter2
  1.2 Subchapter2
    1.2.1 Sub-Subchapter1
    1.2.2 Sub-Subchapter2
2. Chapter2
  2.1 Subchapter1
    2.1.1 Sub-Subchapter1
    2.1.2 Sub-Subchapter2
  2.2 Subchapter2
    2.2.1 Sub-Subchapter1
    2.2.2 Sub-Subchapter2
3. Chapter 3
...


Would be greatly apreciated to have this feature included as well ...

cheers

Klaus

[pcwacht]

Ok,

Been playing with the code, made some changes

the paths issue to config(dot)php should be solved
changed the 'chapters' dir  to menulink name so you could have several manuals on one site

the remove files and dirs is improved (when deleting a chapter the dir stayed)

Let me know how this one goes...

The extra subchapterlevel is troublesome... maybe another time
But now you can use diff manual sections in one page? Maybe that ll work??


John

UPDATE
New Version see some posts down!

[ruebenwurzel]

Thanks pcwacht for the fixes, the modul now seems to work very fine.

Added Multilanguage Support from Woudloper to the modul. At the moment only english and german are supported.

Added the modul to completed modules.

Thanks for the great work

Matthias

[kweitzel]

Hey Ruebenwurzel, don't forget yourself though ... thanks for you part in it as well as all the others who worked on this!

cheers

Klaus

[kweitzel]

Hi again all ...

I upgraded to the last Version of the manual module, because I found another little bug in there: Rearanging the  chapters is not beeing stored ...

So, when I write Chapter 2 befor chapter 1, chapter 2 will stay in position 1 although I used the rearanging feature to put it to position 2 after I created chapter 1 ...

[edit]
I just tried to manually change the field "position" in the DB with the result, that I have the same layout as before.

Chapter2 had position "31" and Chapter1 position "32". I changed them, so Chapter1 sports position "31" and Chapter2 position "32". Did a reload on the admin section and ... voila ... they showed in the right position ...

So I thought, lets edit Chapter1. I did that and was back to the old page ranking ... exept that in the  field "position" Chapter1 has now the value "33" instead of "31" ... clear so far?
[/edit][/b]

I know, sounds silly to do these things, but that's the way I sometimes tick ... any Ideas?

cheers

Klaus

[uchr]

Here is a danish language fil DA.php.txt, download and  rename it to Da.php and insert it into the modules/manual/language directory.

[pcwacht]

I reïnstalled the manual module, few posts up.

Tried all possible position moves, they worked like it should.

@Kweitzel, make sure you delete all the pages and manual mod and then try again?

@Others, does anyone else has simular problems?

John

[kweitzel]

funny ...  in general the moves do work, but they seem not to be stored ... it is quite hard to explain ...

It seems, after writing a couple of more chapters, like there is an increment on the chapter ID, which increments the ID when storing while I think only creation of a new capter should do this. This is at least what I see, when I look into the db ... Haven't looked through the code yet. I am not even shure, if I would find a piece in the code which does that, since I am not profficient with PHP (let alone other languages ....)

I'll have a look, export all my data and reinstall ...

cheers

Klaus

[pcwacht]

The only strange thing I saw was with editing chapters (subchapters)

the last edited chapter comes at the bottom
But is allways movable.

Did try with only a few chapters
1
-1-1
-1-2
-1-3
2

Nothing more, so maybe that could be the issue as well, having many many chapters...

Dunnoh.

Let me know what you find and I will certainly digg into it.
I like this mod

John

[ruebenwurzel]

@uchr

added your language file to the modul in completed modules. Thanks for the work.

Matthias

[kweitzel]

@pcwacht

you are not alon in liking this mod ... see it in action here: http://weitzel.hobby-site.com under Documents ...

cheers

Klaus

[uchr]

I hope this is the right place to write this.

There are a bug in next prev. links, sometimes some of the next prev links don't show up.
I made a manual with this structure.

  Chapter 1.       
  Chapter 2.       
-   Chapter 2-1.       
-   Chapter 2-2.       
  Chapter 3.       
-   Chapter 3-1.       
  Chapter 4.       
  Chapter 5.       
  Chapter 6. 

I looked in the DB table mod_manual_chapters it looked like this.:

chapter_id = 20
section_id = 72
page_id  = 59
active = 1
active = 19
position = 1 - ok

After editing and saving Chapter 3-1 the table mod_manual_chapters looked like this, the position was counted up by 1 it is not correct, it should not be updated. The next prev links was not working correct.

chapter_id = 20
section_id = 72
page_id = 59
active = 1
active = 19
position = 2 - wrong should not be updated.

After changing the position back to 1, the next prev. links worked correct again.

I hope somebody know where to find the bug, so this great manual-module will work correct in the future.

best regards
UCHR
 

[kweitzel]

After editing and saving Chapter 3-1 the table mod_manual_chapters looked like this, the position was counted up by 1 it is not correct, it should not be updated. The next prev links was not working correct.

... and that is also, what I was trying to say ... except that the links didn't bother me and that I never thought, due to lack of experience, that this has got to do with it ... 

cheers

Klaus

[uchr]

The variable $old_parent is not defined in the modify_chapter.php file. if this line

Code:

<input type="hidden" name="old_parent" value="<?php echo $fetch_content['parent']; ?>">

is inserted as line 58 in the modify_chapter.php, the next prev. links are working OK after editing.

I have enclosed the new modify_chapter.php. txt with the bug fix.

Download and rename it to modify_chapter.php and upload it to the modules/manual/ directory.

UCHR

[pcwacht]

And another error fixed,

Deleting a subchapter might break the ordering... the reordering 'forgot' the current parent so included it


Changed the width of the tables from 100% to 99% to fix an IE bug (content goes to bottom when table is 100%)


Attached new manual mod (included the correction of UCHR)

[kweitzel]

Thanks, installation:

Copy over and reload? Or uninstall and reinstall?

cheers

Klaus

[pcwacht]

Installation: the normal way

upgrade from previous versions, just copy the files, no db changes
(Though this would break the userrights in the filesystem,
normal installed modules will be owned by the webserver user
ftp-ed files will be owned by the ftp-user )


John

[ruebenwurzel]

@pcwacht

added your last version to completed modules.

Matthias

[bupaje]

Thanks to all involved in restoring this useful module.

[uchr]

Bug.
When creating a new main chapter the new position number is 1(one) to big.

Fix:
 line 53 in save_chapter.php changed from

Wrong:

Code:

if($old_parent != $parent) {

changed to:

Right:

Code:

if($old_parent != $parent and $parent != '') {

attached: new save_chapter.php.tx t with fix.

cheers

uchr

[ruebenwurzel]

@uchr

Thanks for the fix, added it to the modul at completed moduls.

Matthias

[uchr]

Bug:
When renaming a chapter (new title) the old chapterfile is not deleted in the pages directory.

line 105 and 106 in save_chapter.php

Old:

Code:

if(file_exists(WB_PATH.$old_link.'.php')) {
unlink(WB_PATH.$old_link.'.php');

New:

Code:

if(file_exists(WB_PATH.PAGES_DIRECTORY.$old_link.'.php')) {
unlink(WB_PATH.PAGES_DIRECTORY.$old_link.'.php');

attached new save_chapter.php.tx t file with fix.

uchr

[ruebenwurzel]

@uchr

Great to see someones working on this modul. Seems to have more bugs that i thought at the beginning of this thread. 

Have updated the modul at completed modules. Did you think you found till tomorrow the next bug?  Or did you think now al bugs are fixed?

Thanks for your great work

Matthias