Welcome, Guest. Please login or register.
Did you miss your activation email?
May 26, 2012, 11:57:25 PM

Login with username, password and session length
Search:     Advanced search
Wollen Sie dem WebsiteBaker Team beitreten?
Nähere Informationen finden Sie unter hier und auf unserer neuen Webseite.
155556 Posts in 21715 Topics by 7737 Members
Latest Member: gx-world
* Home Help Search Login Register
Pages: [1] 2 3   Go Down
Print
Author Topic: Page Meta Checker [New Module] Last v0.0.7  (Read 873 times)
elarifr

Offline Offline

Posts: 115



WWW
« on: February 07, 2012, 08:13:52 PM »

hi
just because i was tired to check each page i just made a module to display all page
page description / keywords / templates are showed/hidden as you want to check only some parameters

based on old pagecloner module 0.50 working on 2.8.2

you can edit inline
title & page description : just click, edit, press enter to save
meta keywords : click, edit, press OK or Cancel Button

depending on what you want to check, just hide other parts to easylly see & compare fields

with v0.0.7 it seems ok with wb 2.8.1 & argos_theme

translation includes DE, EN, FR

Thanks to stefek, jacobi for the help



Removed : pagemetachecker_v0. 01.20120207-20h02.zip
Removed : pagemetachecker_v0. 04.working.20120208 .19h38.public.zip
Removed : pagemetachecker_v0. 05.20120208.22h21.z ip (18.52 KB - downloaded 3 times.)
Removed : pagemetachecker-preview-01.jpg
Removed : pagemetachecker_v0. 06.20120209-09h22.public.zip

i will try to add lastest version here.

« Last Edit: February 09, 2012, 10:30:21 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
Stefek
WebsiteBaker Org e.V.

Offline Offline

Posts: 4884



« Reply #1 on: February 07, 2012, 08:45:44 PM »

Hello Elafir,

cool.

Had a small error in the Backend:
Template Error: set_root: D:\xampp\htdocs\wb_derivat/modules/pagecloner is not a directory.
Halted.


You didn't remove the lines invoking the template object.
I commented them out.

Additionally I made a link to the settings of the page, so you can open the page settings from within your page-tree.

Very good idea.
I attatched a new tool.php

Please test it.

Stefek

P.S. The DE.php file corrects the module description
Logged

"In a time of universal deceit, telling the truth becomes a revolutionary act."
- George Orwell, Nineteen eighty-four (1984)
elarifr

Offline Offline

Posts: 115



WWW
« Reply #2 on: February 07, 2012, 09:56:37 PM »

thanks stefek

i have added german translation

as i planned to use a separate edit link / tool i did not provide the link to the admin content page

i don't like to use this solution as it will not return to the meta checker module

so i have added the edit link on the page title instead of menu link

br

elarifr



removed pagemetachecker_v0. 02.20120207-21h53.zip (109.02 KB - downloaded 6 times.)
« Last Edit: February 08, 2012, 06:09:25 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
Stefek
WebsiteBaker Org e.V.

Offline Offline

Posts: 4884



« Reply #3 on: February 07, 2012, 10:26:26 PM »

Hello Elafir.

This Admin-Tool is a great idea.
Do you know when you will implement the META Tag Editor?

Thanks for your contribution in any case.

Regards.
Stefek
Logged

"In a time of universal deceit, telling the truth becomes a revolutionary act."
- George Orwell, Nineteen eighty-four (1984)
Ruud
WebsiteBaker Org e.V.

Offline Offline

Posts: 2298



WWW
« Reply #4 on: February 07, 2012, 11:33:29 PM »

Very nice idea..  A big "thumbs up" for contributing.
Adding an editor to it would be really great.  cool

just because i was tired to check each page i just made a module........
This is the right spirit.. Solutions instead of problems!
Logged

Professional WebsiteBaker Solutions
elarifr

Offline Offline

Posts: 115



WWW
« Reply #5 on: February 08, 2012, 08:52:01 AM »

thanks  embarassed

first i will add some cosmetic features (language flag, alt tooltips )

concerning tag editor don't know what should be most usefull :
- only edit one page tags at a time, like does the page content editor (without theme/menu/rights..) and i just have to change the page settings.php
- or open multiple tag editor in one time (edit All keywords, Edit All Description)

And at other side, it is so easy (and much more convenient) to have this reporting feature installed directly in the core pages module ? any advice from a dev team Huh?

elarifr
Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
Ruud
WebsiteBaker Org e.V.

Offline Offline

Posts: 2298



WWW
« Reply #6 on: February 08, 2012, 10:35:57 AM »

Note: Not speaking for the devteam..  cool
I think this is just where admintools are meant for.

Adding these kind of features in the normal pages page makes that part (the typical user area) more complex.
Also there are a lot of other idea's that would be nice to have added to the main area.
If are not very careful we end up with a platform like joomla, where you need to have a 3 week training before you can understand all functionality.

As admintools, these kind of tools can be hidden for "normal" users, and webmasters can decide themselves if they need it.
Logged

Professional WebsiteBaker Solutions
elarifr

Offline Offline

Posts: 115



WWW
« Reply #7 on: February 08, 2012, 12:14:37 PM »

i'm looking to play with jquery jeditable plugin

here is a test pre 0.03 just implementing the jquery

there is a bug in edit mode that add some tabs at the beginning and the end of the editarea  HuhHuh

do you think it's better to have an Ok / Cancel button of just play with onblur to save data after editing ?

do you think usefull to edit also template ? language?

elarifr

removed pagemetachecker_v0. 02.pre0.03.unoff.20 120208-12h07.zip
« Last Edit: February 08, 2012, 12:49:17 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #8 on: February 08, 2012, 12:29:44 PM »

ok it was the tab inside the source code that was added to the editarea Sad

so now  i'll work on save callback tomorrow

i will use
- double click to edit
- no save/cancel button
- edit text for the page description
- editarea for keywords

- maybe select for template
- what do you think to add red background if no page description / purpple if keywords are under 100 letters ?

elarifr
Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #9 on: February 08, 2012, 12:50:24 PM »

now display flag and no added tabs in edit field


still not saving Sad



Removed : pagemetachecker_v0. 03pre.20120208-14h47.zip (19.65 KB - downloaded 2 times.)
« Last Edit: February 08, 2012, 06:10:15 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
dbs
WebsiteBaker Org e.V.

Offline Offline

Posts: 3719


WWW
« Reply #10 on: February 08, 2012, 03:27:41 PM »

very nice module so far. good work.

Quote
what do you think to add red background if no page description / purpple if keywords are under 100 letters ?

field "keywords" you could make a note like this:
fill it out, but google will not read this. *smilie*

Logged

elarifr

Offline Offline

Posts: 115



WWW
« Reply #11 on: February 08, 2012, 04:20:43 PM »

thanks


looking for saving data from jeditable but it seems i will go in a no way direction Sad

i have jeditable call for saving
Code:
$('.edit_area').editable('<?php echo WB_URL?>/modules/pagemetachecker/save-keywords.php', {

i have added for each field an id="keywords_".$page_id so when i only return from save-keywords
Code:
echo $_POST['id'] ."=" . $_POST['value'];
the field is displayed with new value. so the save script is properlly called back



but how to safelly save now in db Huh??

when i call back the save wb_url is not defined and can not make call the framework

Code:
defined('WB_PATH') OR die(header('Location: ../index.php'));
require_once(WB_PATH.'/framework/class.admin.php');
require_once(WB_PATH.'/framework/functions.php');

i should define it but this means that the save script will become very unsecure as anyone could call it to store anything in the page....

any idea ? any module using such call back to check what can be done ?


elarifr



« Last Edit: February 08, 2012, 04:23:27 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
jacobi22
Betatester
*
Offline Offline

Posts: 1376


WWW
« Reply #12 on: February 08, 2012, 04:26:36 PM »

text removed
« Last Edit: February 09, 2012, 12:06:09 AM by jacobi22 » Logged

LG Uwe

Wer sagt, Reichtum ist alles, hat nie ein Kind lächeln gesehen.
elarifr

Offline Offline

Posts: 115



WWW
« Reply #13 on: February 08, 2012, 05:08:39 PM »

thank jacobi i will give a look

however no need to have .edit_area1/2 unless we need a separate css for each input
.edit_area is enough

i have made a choice to use a .edit for descrption as they are not so long, and no button. just press Enter will save the field

for keyword i have chosed editarea as you can put much more content, even if gg does not officially use them maybe it should give some more ranking

we can not use same page id for description / keywords field , this is why i prefaced id=description_(pageid) to have unique id

save must return the field value to display updated, but must be sanitized before.... (it seems jquery make some jobs, input something like < ? p h p will return < - - ? , but is it enough ?)

the save security is my real problem
yes require config
but then must check right for user logged in to edit content

after is not big problem to update the db. but thank for the query i will not have to rewrite it Smiley


elarifr
Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #14 on: February 08, 2012, 05:50:16 PM »

here a new test

after editing a field it will display the query instead of running it really


can you check how it looks like ?

take care there is still no security in the save !!!!!! (this is why i don't make update)


br

elari


ps : uncomment ths sql query to save for test. at my side it woks well for both fields Smiley


Removed pagemetachecker_v0. 03.pre.20120208-17h47.zip
« Last Edit: February 08, 2012, 09:24:05 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #15 on: February 08, 2012, 06:31:37 PM »

thanks to all for your help Smiley

this still need some security audit

next :

i will now add support to edit the page title like the description

i will not add an edit template select box

the page menu will link to edit page settings in content

elarifr



Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
jacobi22
Betatester
*
Offline Offline

Posts: 1376


WWW
« Reply #16 on: February 08, 2012, 06:48:41 PM »

looks good  wink

but you need a reload to refresh the site
I use this code at the End of save.php and it works fine (but you have the succsess message)


save.php / line 69+
Code:

$target_url = ADMIN_URL.'/admintools/tool.php?tool=pagemetachecker';
if($database->is_error())
{
        $admin->print_error($database->get_error(), $target_url );
}else {
       $admin->print_success($TEXT['SUCCESS'], $target_url);
}

exit;
return;
Logged

LG Uwe

Wer sagt, Reichtum ist alles, hat nie ein Kind lächeln gesehen.
Stefek
WebsiteBaker Org e.V.

Offline Offline

Posts: 4884



« Reply #17 on: February 08, 2012, 07:05:14 PM »

What about
header'location: '$target_url);

instead of
 $admin->print_success($TEXT['SUCCESS'], $target_url);

Should reload the page imadiatly.

Regards,
Stefek
Logged

"In a time of universal deceit, telling the truth becomes a revolutionary act."
- George Orwell, Nineteen eighty-four (1984)
elarifr

Offline Offline

Posts: 115



WWW
« Reply #18 on: February 08, 2012, 07:37:42 PM »

@jacobi, i don't understand but i don't need any refresh of the page
after saving in the db, it will return the new value that is displayed in the field.
in fact, this is true that it is not eaxctly what is stored in db that is retrieved and returned to display but the value provided when you hit enter that is returned

@stefek, same if i return anything else than the value, it will be displayed in the field....

i have got issue where all the main index page was displayed as a field since save was not knowing config.php and so the return value was the index page !

Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #19 on: February 08, 2012, 07:41:34 PM »

at least for me in prod test

it can edit
page_title
description
keywords

and link to edit page

can show/hide
language flag
description
keywords
template


play and tell Smiley


Removed pagemetachecker_v0. 04.working.20120208 .19h38.public.zip
and reuploaded in the first post of topic
« Last Edit: February 08, 2012, 09:25:38 PM by elarifr » Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
jacobi22
Betatester
*
Offline Offline

Posts: 1376


WWW
« Reply #20 on: February 08, 2012, 07:48:25 PM »

@jacobi, i don't understand but i don't need any refresh of the page
after saving in the db, it will return the new value that is displayed in the field.

not so in my browser (FF10)
If i click the OK-Button the text in the field change to "Click to edit" and if i click the button one more time, i have a empty field in the database
Logged

LG Uwe

Wer sagt, Reichtum ist alles, hat nie ein Kind lächeln gesehen.
elarifr

Offline Offline

Posts: 115



WWW
« Reply #21 on: February 08, 2012, 07:54:54 PM »

what do you think to add link to some checking tools

like

http://www.cynthiasays.com
http://www.seorush.com/


 for seo advice , pr, adword ranking tools.....

if you have open site / tools  to suggest

elarifr


Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
elarifr

Offline Offline

Posts: 115



WWW
« Reply #22 on: February 08, 2012, 07:57:25 PM »

@jacobi i have ff 10 too and it works Sad

i don't understand

we can see with teamviewer ?

elarifr
Logged

Accedinfo.com - Société de maintenance informatique sur Strasbourg pour particuliers et entreprises. Tel +33 3 88 33 77 45
dbs
WebsiteBaker Org e.V.

Offline Offline

Posts: 3719


WWW
« Reply #23 on: February 08, 2012, 08:04:47 PM »

can't see a ok-button, but enter after changes work in my FF10

ah, ok-button appears with field keywords, but not with field desc.
« Last Edit: February 08, 2012, 08:09:13 PM by dbs » Logged

jacobi22
Betatester
*
Offline Offline

Posts: 1376


WWW
« Reply #24 on: February 08, 2012, 08:10:54 PM »

Sorry, i didnt see the last Version 0.04  sad

now it works!!
Logged

LG Uwe

Wer sagt, Reichtum ist alles, hat nie ein Kind lächeln gesehen.
Pages: [1] 2 3   Go Up
Print
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.16 | SMF © 2011, Simple Machines Valid XHTML 1.0! Valid CSS!