using wb282 inluding fixes, using wb_theme in backend.
to recreate:
1 - create usergroup
2 - save
3 - modify usergroup
4 - click advanced options - error will show:
Notice: Undefined variable: admin in E:\xampp-nw\htdocs\wb282fixed\admin\groups\groups.php on line 190
Error doesn't show when clicking advanced options during creation, only during modifying existing group.
Logical error, the variable $action is NOT set in theme/groups_form.htt
The test: /admin/groups/groups.php -> line 25
// Set parameter 'action' as alternative to javascript mechanism
$action = (isset($_POST['modify']) ? 'modify' : $action );
$action = (isset($_POST['delete']) ? 'delete' : $action );
The form: /templates/wb_theme/templates/groups_form.htt -> line 283
<form name="advanced" action="{ADVANCED_ACTION}" method="post">
<input type="hidden" name="group_id" value="{GROUP_ID}" />
<input type="hidden" name="action" value="modify" />
{FTAN}
<input type="submit" name="advanced" onclick="window.location = '{ADVANCED_LINK}';" value="{ADVANCED_BUTTON}" />
</form>
Solution:
1 - add line to groups.php,
$action = (isset($_POST['action']) ? 'modify' : $action );
2 - change the backend templates (all of them!) templates/groups_form.htt
from: <input type="hidden" name="action" value="modify" />
to: <input type="hidden" name="modify" value="modify" />
But solutions didn't work, they'll end up in Security Offense Access Denied messages.
There is another error,
$template->set_var( array(
'ACTION_URL' => ADMIN_URL.'/groups/save.php',
'SUBMIT_TITLE' => $TEXT['SAVE'],
'GROUP_ID' => $group['group_id'],
'GROUP_NAME' => $group['name'],
'ADVANCED_ACTION' => 'groups.php',
'FTAN' => $admin->getFTAN()
));
should be:
$template->set_var( array(
'ACTION_URL' => ADMIN_URL.'/groups/save.php',
'SUBMIT_TITLE' => $TEXT['SAVE'],
'GROUP_ID' => $admin->getIDKEY($group['group_id']),
'GROUP_NAME' => $group['name'],
'ADVANCED_ACTION' => 'groups.php',
'FTAN' => $admin->getFTAN()
));
Notice the missing GetIDKEY on the groups_id.
Now it works.
John
