Enhanced Aggregator module ready for download

[sparkdigital]

Hi,

Paul van de Westhuizen of Westhouse IT created an enhanced aggregator mod for me. It now enables you to pick which pages you would to show in your aggregator section. So you're no longer limited to the pages that appear in the child folder but you can show pages from anywhere in the site. A jQuery plugin allows you to add/remove the pages and move them up/down in the list.

I'm currently using it on http://www.romanticretreats.co.uk/special-offers.php to show the holiday cottages that have special offers. Also for any alterations in the CSS for this mod you can look at the css sheet for that page.

Any questions please ask.

Konrad

[Argos]

That sounds great, thanks for sharing! Maybe it can be the official replacement for http://www.websitebakers.com/pages/modules/listings/section-pages/aggregator_mod.php

[Paul - Westhouse IT]

Yup, that's the idea.

Rather than release it as a new version I wanted to change the name since "aggregator_mod module" sounded kinda weird.

[lausianne]

Has anyone tried this with 2.8.2?

I get this error message on the settings page:

Code:

Notice: Undefined index: summary_id in ...\modules\enhanced_aggregator\modify.php on line 162/>

And then several more errors when trying to save:

Code:

Notice: Undefined index: use_page_id_list in ...\modules\enhanced_aggregator\save.php on line 30
Notice: Undefined index: use_thumbnail in ...\modules\enhanced_aggregator\save.php on line 39
Notice: Undefined index: use_summary in ...\modules\enhanced_aggregator\save.php on line 59
Notice: Undefined index: page_browser_top in ...\modules\enhanced_aggregator\save.php on line 92
Notice: Undefined index: page_browser_bottom in ...\modules\enhanced_aggregator\save.php on line 93

?

Thank you!
Cheers, Ralf.

[Paul - Westhouse IT]

The errors are actually because the code in the original module accessed certain variables in the $_POST array. Like so:

$aggregate_hidden = (($_POST['aggregate_hidden'] == '1')) ? 1 : 0;


To save me the time looking at the changes for $_POST access in 2.8.2, does anyone know correct code for the example above?

Thanks.

[DarkViper]

an easy way to sanitize and preset a numeric POST-value

get_posts() returns the value or even 'null' if argument is missing
intval() castes any not numeric value, 'null'  and '0' also  into (int)0.
the ternary operator makes sure that  '1' only results in a (int)1 and any other value results in (int)0

Code:

<?php

$aggregate_hidden = ((intval($wb->get_post('aggregate_hidden')) === 1)) ? 1 : 0;

?>

(instead of $wb-> you can use $admin-> for backend also)

It's normal PHP nothing special from 2.8.2

[Paul - Westhouse IT]

I think I was a bit vague in my first reply. "Undefined index:" means that those entries don't exist in the $_POST array. Therefore either those array entries were unset, or they weren't sent in the first place. It seems far more reasonable that they weren't sent/set.

While it is true that directly using the $_POST array without santizing is a bad idea, it should still work. Therefore the problem is due to a change in 2.8.2. But since I don't have the time at the moment to set up a 2.8.2 dev environ and test & fix the problem, I'll need to leave that to someone else.

P.S. You can also cast as int instead of using intval(). Also, type casting isn't needed in your alternative if you use ==, since the comparison operator will auto-cast as int to compare to the int on the other side. It just depends on whether you want to be explicit or not.

[pcwacht]

They are NOT errors but notices.
Could be due to different errorlevel settings in php or in backend of WB

In short, those notices could have been there all along.
It is just php telling you you use a variable wich wasn't set before.

Code:

$somevariable = '';
echo $somevariable;

differs from

Code:

echo $somevariable;

The latter might fire the notice.


John

[Paul - Westhouse IT]

Just checked quickly, and you're right John, they were there all along.

Please ensure that on a live site display_errors is "Off" and error_reporting is set to the default of "E_ALL & ~E_NOTICE" or less.

Ideally these bugs should be fixed. Is anyone interested in improving this module further?

[lausianne]

Well, thanks for your comments. I would not mind a few notices, that I can switch off. But I get no frontend output of the aggregator. Also, droplets that I have on an aggregator page don't work. I see the droplet code instead [[...]].
(client coming in tomorrow, so I have no time for further testing today, sorry ...)

Cheers,
Ralf.
 

[pcwacht]

Seems to be missing some preprocess

Not tested:
Open up view.php
change  line 232

Code:

$page_source .= ob_get_contents();

to

Code:

$page_source .= $wb->preprocess(ob_get_contents());

If this doens't work try

Code:

$page_sourcetemp = ob_get_contents();
$page_source .= $wb->preprocess($page_sourcetemp);

Have fun,
John