WYSIWYG Editors and relative links

[Ruud]

Just had a little brainwave.  

We all know the problem of images in WYSIWYG pages that include the full url. When moving the site from the development server to a live server the images are still pointing to the development server.

It is very hard (if not impossible) to change the editors on this. They need to know the full url to be able to load the plugins and give the possibility to browse images and other stuff.

All WYSIWYG editors work through the WYSIWYG module. So why not remove the full url at that point before it is saved in the database.

The experimental fix:

The WB2.8.1 WYSIWYG module "save.php" reads in line 30 the data posted when saving the data.
If I just add the following code on line 31, all links to my own server (defined in WB_URL) will be transformed in links without the server.

Code:

$content = str_replace ( '"'.WB_URL, '"', $content);

I quickly tested this on one of my development sites and it seems to do the trick.
A line that now says <img src="http://myserver.com/media/image.jpg" /> is nicely transormed in <img src="/media/image.jpg" />

There might be side-effects to this, so please test this "hack", and report any issues in this topic.
Maybe we can finetune this to a full solution.

Ruud

[Stefek]

Hoi Ruud.

I can see that you'll get in troubles with pages on level > 0.

Regards,
Stefek

[Ruud]

I can see that you'll get in troubles with pages on level > 0.

Naah..

The WB_URL should have no / at the end, so the remainer will start with the /

Brainwaiving further  I can see problems with sites installed in a subdirectory.
If WB_URL is set to http://myserver.com/wb this will not work 
Especially if you move to a live server without the subdirectory.

[Stefek]

Hello Ruud,


Maybe you can combine your Ideas with thoese both snippets:
http://www.websitebaker2.org/forum/index.php/topic,20575.msg139365.html#msg139365
http://www.websitebaker2.org/forum/index.php/topic,20841.msg140994.html#msg140994

The second link works fine,
but the links are not yet "relative".

Regards,
Stefek

[Ruud]

Ok, the word "relative" is relative here..

On saving we should check the level of the current page, remove the WB_URL part and replace it with a series of "../" depending on the current pagetree level.
Let me sleep on that for now..

[Stefek]

sorry stefek... i clicked the wrong button...      
werner

[DarkViper]

there is already a solution in wysiwyg-module from 2.9 SVN.
the solution is based on Document_Root and will affect links only which are inside HTML markups as href or src. Like <img><object><a> and so on, but never change links written in plain text.

to adapt this module for 2.8.x the file /framework/initialize.php needs following additional lines at the end:
(it's a private patch only, not an official solution)

Code: (/framework/initialize.php)

<?php
...
...
if(!defined('MEDIA_URL')) define('MEDIA_URL', WB_URL.MEDIA_DIRECTORY);
$tmp = str_replace('\\', '/', $_SERVER["DOCUMENT_ROOT"]);
$tmp = str_replace($tmp, '', str_replace('\\', '/', WB_PATH));
if(!defined('MEDIA_REL')) define('MEDIA_REL', $tmp.MEDIA_DIRECTORY);

?>

have a nice day...  

[Stefek]

sorry stefek... i clicked the wrong button...      
werner

This can happen.
Nevermind.

Thanks for that patch.

It works if I put it right into the WYSIWYG Editor view.php

Code:

<?php 
// define constants MEDIA_URL, MEDIA_REL if not allready defined
if(!defined('MEDIA_URL')) define('MEDIA_URL', WB_URL.MEDIA_DIRECTORY);
$tmp = str_replace('\\', '/', $_SERVER["DOCUMENT_ROOT"]);
$tmp = str_replace($tmp, '', str_replace('\\', '/', WB_PATH));
if(!defined('MEDIA_REL')) define('MEDIA_REL', $tmp.MEDIA_DIRECTORY);

//.... and then ...
if(strpos($content,'{SYSVAR:MEDIA_REL}'))
$content = str_replace('{SYSVAR:MEDIA_REL}',MEDIA_REL, $content );

Should do the same trick as putting it into the framework/initialize.php, right?

Regards,
Stefek

[Stefek]

By the way, Werner.

This replacement

Code:

<?php
if(strpos($content,'{SYSVAR:MEDIA_REL}'))
$content = str_replace('{SYSVAR:MEDIA_REL}',MEDIA_REL, $content );

could be part of the $wb->preprocess() method, right?

Regards,
Stefek

[DarkViper]

Should do the same trick as putting it into the framework/initialize.php, right?

implicitly putted that patch into the initialize.php so no changes are needed in the module from wb2.9 (i.e. some later updates)
in modify.php and save.php the new constant MEDIA_URL is needed too.

could be part of the $wb->preprocess() method, right?

this toggeling between MEDIA_URL {PLACE_HOLDER} and MEDIA_REL is a complete functionality of the module wysiwyg. It should not be distributed to completely different functionalities. Whats happen, if in future the preprocess() will be changed into any other thing? who will remember the dependence to wysiwyg??

[crnogorac081]

Hi Ruud,

I had an idea for this too.

Take a look at my solution:
http://www.websitebaker2.org/forum/index.php/topic,20841.0.html

cheers

[Ruud]

Good to see I am not the only one brain-waving about this.

Being the biggest supporter of droplets, I do not like the droplet solution. It makes a module dependent of the existence of a certain droplet.

I like the MEDIA_REL approach. This could be simply built in the ( WB2.8 ) WYSIWYG module to make it work for WB2.8 users too.

[crnogorac081]

Being the biggest supporter of droplets, I do not like the droplet solution. It makes a module dependent of the existence of a certain droplet.

I agree, but it looked to me as a simple solution and backward compatible than using ..SYSVAR:MEDIA_REL.. etc..

I add [[WB-URL]] to droplets first thing I install wb I would also suggest to add it as a default droplet

cheers