install.php with invalid SQL has prevented any further installations

[sciclist]

Hi,

Is this a known problem?

Without attempting to detail, at this stage, the errors in the install.php that I wrote for a module which I am designing, may I pose this general question?

I attempted to install my prototype module on my clients WB. My install.php contained SQL syntax errors and no table was added to the WB database. However, the installation facility is now completely broken - no other modules can be installed either.

If this does not smack of a known problem, I can, of course, give more info as to my client's WB version and the precise nature of the errors in my SQL in install.php.

Thanks,

John

[crnogorac081]

no it is not.. can you post your code from install.php file..

[sciclist]

Thanks for your response.

The offending install.php is attached. As you can see, my use of quotes was muddled.

John

[mjm4842]

Hi sciclist,

What I would suggest is that you temporarily enable PHP error messages in websitebaker's Settings (click on the "Show Advanced Options >>" button). Set the PHP Error Reporting Level to E_ALL and save. Then try to install some other module.

An error message will hopefully appear on the screen. Copy and paste it back here in this thread.

The E_ALL setting causes PHP error messages to appear on the screen, error messages which are often key to troubleshooting a problem.

IMPORTANT: Don't forget to set it back to E_NONE as soon as you are done to prevent warnings from appearing when customers use the website.

With warmest regards,

Michael Milette

[sciclist]

Thanks Michael.

Parse error: syntax error, unexpected T_STRING in /homepages/21/d111430206/htdocs/temp/unzip/info.php  on line 2

I thought: "Ah, good, now I can jump in and start to tackle the problem"

Then I discovered that there is no /homepages directory in root (or /pages or /modules ...).

Doh! Where am I?

CMS Version 2.8.1
Revision 1285
Admin version 1.4

[crnogorac081]

maybe files failed to transfer via ftp ?

[pcwacht]

Then I discovered that there is no /homepages directory in root (or /pages or /modules ...).

and

/homepages/21/d111430206/htdocs/temp/unzip/info.php 

That's right, there are no homepages in your root or pages etc
The homepages is the root of your webserver,
in it is a path to your htdocs, /homepages/21/d111430206/htdocs
the htdocs is your website root, here are the pages wich will be send when someone surfs to www.yourwebsite.com


The error :

Parse error: syntax error, unexpected T_STRING in /homepages/21/d111430206/htdocs/temp/unzip/info.php  on line 2

simple tells you that /temp/unzip/info.php (in your website root) has illegal php code, a syntax error

When you install something through the backend of wb, wb will receive the zip and unzips it in your temp directory (websiteroot/temp/unzip)
Then it tries to read the info.php so wb's install routine knows what you are installing, template, module etc
Then it should copy the content of temp/unzip to the correct location, /templates for example after wich it will fire up the install.php.


In this case your info.php is not correct. PHP gives an error and WB halted

Have fun,
John

[sciclist]

In this case your info.php is not correct.

Ah, but it is not my info.php. The error message I posted resulted from trying to install the "members" module from the WB repository. The same problem occurs with any module whatsoever.

There is indeed an error (a missing comment delimiter) on line two of my info.php file so it would appear that said file is lodged in the throat of my client's web-server!

Should not WB ensure that any detritus from failed installations is removed or over-written prior to, or during, subsequent installations?

I imagine no author other than me has managed to make an error so early in their coding of so trivial a file. Nevertheless, this is a misbehaviour of WB that should perhaps be fixed or at least documented.

Many thanks for your guidance, Michael.

John

[pcwacht]

After a succesfull install the temp files will be deleted, but if a script goes in error it stops.....


Have fun
John