Bookings v2.x

[BlackBird]

As I am not able to edit my postings in the original Bookings thread (my old forum account was accidentally deleted), I have opened this new thread for questions and/or suggestions related to the Bookings module.

If you're interested in the history of this module, you find the original thread here:
http://www.websitebaker2.org/forum/index.php/topic,10218.0.html

Current version:	2.29
Download:	http://www.websitebakers.com/pages/modules/calendar-and-time/bookings.php
Homepage (German):	http://www.webing.de/webbird/websitebaker/Bookings

Module to show free/booked times on a calendar page. (For vacation apartments or meeting rooms for example.) Dates can be added with or without time of day.

Please note: This module was created to manage ONE vacation apartment. If you need to manage lots of resources (for example, 20 rooms), you will have to add it as many times as you have resources to manage. (20 times in this example.) So it's okay if you have 5 rooms or apartments or something, but may be too awkward to handle more.

[tkche]

Hi.
Very nice work on the module!

I've found a small bug... after saving an event and opening it for editing i'm getting some odd characters instead of original text on the rental/text field... i'm using Hebrew characters so i guess it has something to do with utf...

[BlackBird]

Hm, that's not easy for me to reproduce.

First of all, make sure that all components involved use UTF-8. (Browser, WB Settings, Database settings.)
Next, take a look into the database if it is stored right there. (Table mod_bookings_dates, column "name")

Maybe you'll have to change the table collation. (try uft8_general_ci)

[tkche]

oh, you dont speak Hebrew? it's ok, nobody's perfect 

thanks for the reply, tried your suggestions. changing to uft8_general_ci failed to fix the issue
The database seems to show the right value up until i edit the booking using WB and then it goes all wrong showing question marks instead of letters...
I've checked the browser, WB settings and DB, all seems to be ok.

now, as i said, the module works great and showing the right info unless you edit the booking... very odd.

[BlackBird]

Hmmm... So when first storing the booking all goes right, but when changing the text, the UTF8 is lost, right? Strange. I'll try to reproduce this error. Until I find a fix, you'll have to delete and add again instead of editing bookings, I'm afraid. I'm sorry for this.

[BlackBird]

Okay, the problem is located in file functions.php, line 1371:

Code:

<input type="text" name="name" value="<?php echo htmlentities($name); ?>" style="width: 200px;" /><br />

If you change this to

Code:

<input type="text" name="name" value="<?php echo $name; ?>" style="width: 200px;" /><br />

should fix your problem. BUT. You will not be able to enter special chars like ", ', <, > there anymore.

Please try this workaround and tell me if it helps.

[BlackBird]

You can also try this:

Code:

<input type="text" name="name" value="<?php echo htmlspecialchars($name); ?>" style="width: 200px;" /><br />

That should allow ", ', <, > and &, but leave the others untouched.

[tkche]

like a charm!
thanks 

[BlackBird]

Happy to help. I will publish a bugfix release on AMASP that includes this fix tomorrow.

[BlackBird]

I have released Bookings v2.26 yesterday. No new features; it only generates complete links now instead of using relative ones. This makes it work better with the also renewed Bookings Droplet, available at AMASP.

Bookings module:
http://www.websitebakers.com/pages/modules/calendar-and-time/bookings.php

Droplet:
http://www.websitebakers.com/pages/droplets/downloads.php

[BlackBird]

I somehow missed the release announcement of v2.27. Anyway, I've released v2.28 today.

Details: http://www.websitebakers.com/pages/posts/bookings-v2.28-released-289.php
Download: http://www.websitebakers.com/pages/modules/calendar-and-time/bookings.php

[BlackBird]

Unfortunately, the discussion still goes in the old thread. :/

I've release v2.29 that has a new feature: Groups can have a background color now.

Groups are only used in day view.

[mikejd]

I'm not sure whether to post in this thread, the old thread or start a new one. Anyway let's try.

I have been using the bookings module v2.18 with WB 2.7. Two questions:

Can I just overwrite the old files with the new version v2.32 and it should continue to work?

If I upgrade to WB2.8.2 will bookingsv2.18 still work or do I need v2.32?

Thanks.
Mike

[BlackBird]

I just can't tell. It's a great distance between that versions, both WB and Bookings. I'd suggest to try the upgrade with a copy of your site first. And don't forget to make a database dump before you upgrade.

[mikejd]

Hi Blackbird, thanks.

I will be trying it out shortly.

One other question - I find the 'Add' button a bit hidden at the bottom of the admin interface, particularly after a few entries have been made. I think it would work better as another button alongside the 'Settings' and 'Groups' buttons. I would like to try to change the code to do this but can't work out which file I need to modify. Can you advise me which file contains the html code for the interface?

regards,
Mike

[BlackBird]

As this was my very first module, it's mixed up code and HTML. No templates. So you will have to change the functions.php to tune the add link. It's line 1103 ff in v2.32:

Code:

    if ( Bookings_user_can( 'add', '', $section  ) )
    {
   
        if ( basename( $caller[0]['file'] ) === 'modify.php' ) {
            // called from backend
            $action = WB_URL."/modules/bookings_v2/add_bookings.php";
        }
        else {
            $action = $_SERVER['SCRIPT_NAME'];
        }
       
        echo
             "  <tr><td colspan=\"7\" style=\"text-align: right;\">\n",
             "        <a href=\"$action?page_id=$page_id&section_id=$section&add=1\"\n",
             "           title=\"", $TEXT['ADD'], "\">", $TEXT['ADD'], "\n",
             "        <img src=\"", THEME_URL, "/images/plus_16.png\" border=\"0\"\n",
             "           alt=\"", $TEXT['ADD'], "\" /></a>\n",
             "  </td></tr>\n";
 
    }

[mikejd]

Thanks Blackbird. It looks like it may be a little complicated to put an 'Add' button alongside the 'Settings' and 'Groups', perhaps beyond my capabilities. But I should be able to make styling changes to make it more obvious.

Just another query - at the end of the list of links for 'Current year', 'current quarter', etc is 'Span'. Can you advise what this does?

regards,
Mike