News comments with name and email

[Argos]

Is it possible to add name and email fields to the News comment function, just like the Feedback module has?

[pcwacht]

yups it is.

can be coded into the core, wouldn't be to hard.

John

edit -> core is newsodule

[Argos]

Even better: visitors should register before being able to add a comment, but all comments are visiible to everyone. Like descibed in http://www.websitebaker2.org/forum/index.php/topic,10764.0.html. I don't know how to apply the fix that is described there upon the current News module. It's different code.

[pcwacht]

Hmm code seems incomplete

starts with an if, the ending } seems missing

But now I know what you mean.

Hold on

John

[pcwacht]

replace modules/news/view.php with attached one

What I did around line 426

Code:

// Show comments section if we have to
// Original line:
// if(($post['commenting'] == 'private' AND isset($wb) AND $wb->is_authenticated() == true) OR $post['commenting'] == 'public')
// New line
if($post['commenting'] != 'disabled')
{
// New Lines!!! added by PCWacht - see forum -> http://www.websitebaker2.org/forum/index.php/topic,10764.0.html
        // Print comments header
        if ((($post['commenting'] == 'private') AND (isset($wb) AND $wb->is_authenticated() == true)) OR ($post['commenting'] == 'public'))
        {
$values = array(WB_URL.'/modules/news/comment.php?post_id='.POST_ID.'&section_id='.$section_id.'hier', $MOD_NEWS['TEXT_COMMENTS']);
        } else {
$values = array(WB_URL.'/account/signup.php',  $MOD_NEWS['TEXT_COMMENTS']);
        }
// End News Lines!!!       
// Print comments header
$vars = array('[ADD_COMMENT_URL]','[TEXT_COMMENTS]');
// Original line!!!
// $values = array(WB_URL.'/modules/news/comment.php?post_id='.POST_ID.'&section_id='.$section_id, $MOD_NEWS['TEXT_COMMENTS']);
// End Original Line!!!

Have fun,
John

[Argos]

Great John, thanks very much!! I appreciate it!
I'll try it out tomorrow 

[Argos]

Hi John, it doesn work. I don't see any difference with the regular situation, except that the link for posting comment is wrong. In the code I see the word "hier", maybe that's causing trouble?

[pcwacht]

Hmmm the 'hier' is a debug issue wich I forgot to remove, sorry.

Code:

$values = array(WB_URL.'/modules/news/comment.php?post_id='.POST_ID.'&section_id='.$section_id.'hier', $MOD_NEWS['TEXT_COMMENTS']);

must be changed to:

Code:

$values = array(WB_URL.'/modules/news/comment.php?post_id='.POST_ID.'&section_id='.$section_id, $MOD_NEWS['TEXT_COMMENTS']);

What it should do (and it does so on my test xampp) is done in this litle bit, the rest of the changes is merely to let this bit do it's work:

Code:

        if ((($post['commenting'] == 'private') AND (isset($wb) AND $wb->is_authenticated() == true)) OR ($post['commenting'] == 'public'))
        {
$values = array(WB_URL.'/modules/news/comment.php?post_id='.POST_ID.'&section_id='.$section_id.'hier', $MOD_NEWS['TEXT_COMMENTS']);
        } else {
$values = array(WB_URL.'/account/signup.php',  $MOD_NEWS['TEXT_COMMENTS']);
        }

if comments is set to private AND user is logged in OR comments is set to public, show the add comments link, else it should set the link to login.
It shouldn't do more then this, cause showing other texts etc , then those texts should be baked into the view.php, wich I am not fond of, but can be done ofcourse.

change for example

Code:

$values = array(WB_URL.'/account/signup.php',  $MOD_NEWS['TEXT_COMMENTS']);

to

Code:

$values = array(WB_URL.'/account/signup.php', 'You need to be logged in to post comments');

John

[Argos]

Sorry John, doesn't work on my install. The comment link is shown regardless of the settings in the backend (what is the difference between the comments switch in the news settings, and in the news item settings, by the way?). Besides that, the comment link that is shown within a comment allready given is incorrect.

But don't feel obliged to spend more time on this, my client just emailed me that work on the comments function is not needed anyway. We will leave is as it is.

Thanks for your effort.

[pcwacht]

should work when commenting is PRIVATE, hmmm, news module 3.5?


difference between comments switch settings and post
the switch from settings is used to set deafult for post I think

In view the switch from the post is used.

John

[Argos]

should work when commenting is PRIVATE, hmmm, news module 3.5?

Yes.

difference between comments switch settings and post
the switch from settings is used to set deafult for post I think

In view the switch from the post is used.

Ah, sounds logical indeed. Thanks.

[tkche]

it didnt worked for me so i double checked it, just a small fix needed...

the following line:

Code:

if($post['commenting'] != 'disabled')

should be

Code:

if($post['commenting'] != 'none')