Downloads Module: Download Gallery v1.0 Final released

[Argos]

Nice module!

I did a mod of the settings content though, to match it somehow with the regular News layout. I left out the date though, because I have no use for it in the site I am working on now. You can see a test install on http://www.nvpit.nl/cms/pages/leden/downloads.php. The settings I used are:

<style type="text/css">
.line, .line_rightalign { border-bottom: 1px solid #DDDDDD; }
.line_rightalign { text-align: right; white-space: nowrap; font-size: 10px; }
</style>

<table cellpadding="0" cellspacing="0" border="0" width="100%" style="display: [DISPLAY_PREVIOUS_NEXT_LINKS]">
<tr>
<td width="35%" align="left">« [PREVIOUS_PAGE_LINK]</td>
<td width="30%" align="center">[OF]</td>
<td width="35%" align="right">[NEXT_PAGE_LINK] »</td>
</tr>
</table>

<table cellpadding="0" cellspacing="0" border="0" width="100%">
<tr>

<td class="line"><img src="[FTIMAGE]"><a href="[LINK]" target="_blank"><b>[TITLE]</b></a></td><td class="line_rightalign">type: [EXT]&nbsp;&nbsp;&nbsp;|&nbsp;&nbsp;&nbsp;grootte: [SIZE]</span></td>
<tr>
<td colspan="2">[DESCRIPTION]<p></td>
</tr>

The last box is empty.

[bhhenry]

OK, I have installed the module, and it works quite nicely for me so far. 

You can see it in action here: http://new.bhhenry.com/pages/council-newsletter.php.

Many thanks to argos for the great layout settings customization he posted below. I added another column to the file loop table to space the description to fit directly under the title.

I also added a WYSIWYG section to the top of the page rather than editing the header layout settings by hand.

My only suggestion would be to have the WYSIWYG editor available (optionally) to edit the description text.

[Argos]

Many thanks to argos for the great layout settings customization he posted below. I added another column to the file loop table to space the description to fit directly under the title.

You're welcome
Nice little mod with the extra column!

[kibmcz]

With Download Gallery v1.0 RC2 installed i get the following error when i use WB's search function. It goes away when i remove the module.

Code:

Fatal error: Call to a member function numRows() on a non-object in C:\Program Files\xampp\htdocs\wb\search\search.php on line 203

[bhhenry]

With Download Gallery v1.0 RC2 installed i get the following error when i use WB's search function.

Ugh. I get something similar:

Code:

Fatal error: Call to a member function on a non-object in /home/blah/new.bhhenry.com/search/search.php on line 203

[Argos]

Me too, although the search itself works fine.

[Marden]

Is there a way of allowing users to add files for downloading but not be posted till the admin has a chance to look at the file first??

[Woudloper]

Thanks for the replies given in this topic. This always helps a developer a lot to find bugs and add new features. First I am going to look into the search problem some (which some of you have reported). Which fields should be searchable? In the next Release Candidate I think I will only make the title and the description field searchable.

If that is finished I am going to think about Argos his suggestion for the layout. What do you guys think? Should I skip the <dl> list and step over to a <table>?

@ Marden: If you would like something as you mentioned the best thing to do is modify the module a bit and but the 'active' field default on 'not active'. Then you should instruct your users not to change that (or you can even remove this from the modification section or make the 'active' only visible for the administrator)

test for updating, I am getting session warnings when posting here at the forum....

[kibmcz]

Thanks for the replies given in this topic. This always helps a developer a lot to find bugs and add new features. First I am going to look into the search problem some (which some of you have reported). Which fields should be searchable? In the next Release Candidate I think I will only make the title and the description field searchable.

If that is finished I am going to think about Argos his suggestion for the layout. What do you guys think? Should I skip the <dl> list and step over to a <table>?

@ Marden: If you would like something as you mentioned the best thing to do is modify the module a bit and but the 'active' field default on 'not active'. Then you should instruct your users not to change that (or you can even remove this from the modification section or make the 'active' only visible for the administrator)

test for updating, I am getting session warnings when posting here at the forum....

Title, File, Description should be searchable.

[Woudloper]

Update (new release candidate 3!!)

After the above mentioned comment I released a new version of the 'Download Gallery' which will not have the search errors anymore and also has the layout of Argos (which is more in line with the news version).

If you have any questions do not hesitate to ask them here in the forum thread. If no questions/bugs/etc. will be reported in the forum here I will make this release the final version and put it in the 'completed modules' thread.

[Argos]

Cool 
By the way: because I removed the date and time parameters, and you used my version of the settings, they are not there anymore in the new RC module. Maybe other people like to have these parameters, so I suggest you stick them back in...

[JTux]

Thanks for this great module. It works a treat. I have one request, if you are intending to make further modifications, and that is to make the default placement of new uploaded files placed at the top of the generated list. At the moment new files are added to the bottom of the list.

But perhaps there is an easy way to change how this works within the current release that someone can explain to me?

[Argos]

Good suggestion. I have another few

- get rid of filesizes in bytes and round them up to 1kb
- get rid of decimals in case of kb, just round them down or up to whole sizes
- just use 1 decimal in case of MB

[bhhenry]

I released a new version of the 'Download Gallery' which will not have the search errors anymore and also has the layout of Argos (which is more in line with the news version).

Can I just copy the new files over to update from RC2?

[Woudloper]

make the default placement of new uploaded files placed at the top of the generated list. At the moment new files are added to the bottom of the list.

This will include a whole other logic from the backend code if you ask me. Besides that, the behaviour for this module is more or less the same as for the news module as mentioned earlier by Argos. What could be done is to add a sorting order to the display table, but this also applies a new option that should be added to the settings page. Think this feature request will not make it for the first release.

Good suggestion. I have another few
- get rid of filesizes in bytes and round them up to 1kb
- get rid of decimals in case of kb, just round them down or up to whole sizes
- just use 1 decimal in case of MB

Nice suggestions, but don't think these will be implemented into the first release of the download gallery module. If you would like to change the display you can modifiy the function for the file size which can be found in the 'functions.php' file.

If you can adjust the function down below or point me to a better version on the internet I can take a look at it and see if this is workable for the download gallery...

Code:

<?php
function human_file_size($size) {
   $filesizename = array(" Bytes", " KB", " MB", " GB", " TB", " PB", " EB", " ZB", " YB");
   return round($size/pow(1024, ($i = floor(log($size, 1024)))), 2) . $filesizename[$i];
}
?>

Can I just copy the new files over to update from RC2?

No you should deinstall the older version and reinstall the new version, because I changed some parts of the 'install.php' file. This file is only called when you install the complete database. You can also update the database, but I have no time to write an update script for only the search fix (since this is also not a final release of the module).

Thanks for all the responses!

[pcwacht]

Code:

<?php
function human_file_size($size) {
   $filesizename = array(" Bytes", " KB", " MB", " GB", " TB", " PB", " EB", " ZB", " YB");
   return round($size/pow(1024, ($i = floor(log($size, 1024))))) . $filesizename[$i];
}
?>

Just remove the ,2 in the round function.
From php.net:

Code:

echo round(3.4);        // 3
echo round(3.5);        // 4
echo round(3.6);        // 4
echo round(3.6, 0);      // 4

If you want to round 1.1 to 2, just add .5 to it
return round($size/pow(1024, ($i = floor(log($size, 1024))))+.5) . $filesizename[$i];



Have fun,
John

[Woudloper]

@ pcwatch: I've also found the following code: human readable sizes. Isn't this something for this module?? It's needs a little adjustment for this module I think... This function has also an option for rounding, etc...

[pcwacht]

Yours seem less code (execution time) while running.
If you wanna round things up:
// Return string
    if ($retstring === null) {
        $retstring = '%01.2f %s';
    }
change the '%01.2f %s' to '%01 %s'
'
I would go with the first one
Make some settings in settings page like:
round UP? If rounded, round it up? ie 1.4 becomes 2, 1.0 stays 1

decimals? : store the wanted decimals in a variable, like 0 for none, 2 for 0.11 etc

if ($roundup>0) && ($decimals==0) (
   $addition=.45;
} else {
  $addition = 0 ;
}
return round($size/pow(1024, ($i = floor(log($size, 1024))))+$addition, $decimals) . $filesizename[$i];

Looks much neater to me then the other code

John

[Argos]

I feel very stupid, but is this something I can use right now? And if so, where should I change what? Sorry for my ignorance 

[Woudloper]

I feel very stupid, but is this something I can use right now? And if so, where should I change what? Sorry for my ignorance

It should be possible if someone modifies the human_file_size function without the setting pcwacht is talking about. Then you can just modify the functions.php file and replace the function. Today I don't have any time left, thus if someone wants to give it a try you can post the adjused version of the function in this thread...

@ pcwacht: Could you explain this part of the code some more $addition=.45; Where does the .45 come from and what does this mean? Hope to hear from you! To come back. If I understand you correctly you mean that I need to add two options (to the main settings). One for the roundup (true/false) and another one for the number of decimals (0, 1, 2, 3, 4, 5)??

[pcwacht]

The two options: yes
Some want roundings, some don't (option 1)
Some want 1 decimal, others 3 (as in 1.000) (option 2)

Or reduce it to one option, 0 decimals is simular to no rounding

round()
when you round something (with no decimals) it will do the following:
1.1 stays 1
1.49 stays 1
1.50 becomes 2

With Mb's and Kb's you want to know it's size
When you round, the size looks less then it is, so sometimes you want to show 2 instead of 1 when it is 1.432 Mb

That's where the addition of .45 (or less) comes in (it is basicly just showing more then you have   )
1 still stays 1 (1.45)
1.1 becomes 2 (1.55)
etc
So allmost 1 stays 1 and 1 and a bit becomes 2


John

[Woudloper]

Update (Release Candidate 4)!!

After looking at the suggestions of pcwatch I have updated the Download Gallery Module to RC4. Please all test this version and say what you think of this version. For the ones who are interested I have also included an update script.

If pcwacht can take a look at the function I created based upon his ideas I would be very happy!

[pcwacht]

Hi Woudloper,

The function hfs looks good to me

John

[bhhenry]

I have updated the Download Gallery Module to RC4. Please all test this version and say what you think of this version. For the ones who are interested I have also included an update script.

I copied over the new files and ran the update script -- seems to work fine so far. Thanks.

If anyone is interested, I changed the "file loop" settings customization so that the description text is not under the file icon. (See http://test.ugca.com/pages/architectural-control.php.)

Code:

<td valign="middle"><img src="[FTIMAGE]"></td>
<td class="line"><a href="[LINK]" target="_blank"><b>[TITLE]</b></a>
</td>
<td class="line_rightalign" valign="bottom">type: [EXT]&nbsp;|&nbsp;size: [SIZE]</span></td>
<tr>
<td>&nbsp;</td>
<td colspan="2">[DESCRIPTION]<p></td>
</tr>

[JTux]

Works fine for me too.

bhhenry said:

If anyone is interested, I changed the "file loop" settings customization so that the description text is not under the file icon. (See http://test.ugca.com/pages/architectural-control.php.)

I'm interested. Where do I change this code?