Welcome, Guest. Please login or register.
Did you miss your activation email?
May 26, 2012, 09:21:03 AM

Login with username, password and session length
Search:     Advanced search
Interested in joining the WebsiteBaker team?
For more Information read here or on our new website.
155535 Posts in 21713 Topics by 7737 Members
Latest Member: chris85
* Home Help Search Login Register
Pages: [1]   Go Down
Print
Author Topic: Suggestion - add new page to correct menu  (Read 1608 times)
PurpleEdge

Offline Offline

Posts: 232



WWW
« on: May 18, 2010, 07:03:20 AM »

In the admin/pages/add.php file is a section of code that adds a new page, lines 120 - 138 ...

Code:
// Work-out if the page parent (if selected) has a seperate template or language to the default
$query_parent = $database->query("SELECT template, language FROM ".TABLE_PREFIX."pages WHERE page_id = '$parent'");
if($query_parent->numRows() > 0) {
$fetch_parent = $query_parent->fetchRow();
$template = $fetch_parent['template'];
$language = $fetch_parent['language'];
} else {
$template = '';
$language = DEFAULT_LANGUAGE;
}

// Insert page into pages table
$query = "INSERT INTO ".TABLE_PREFIX."pages (page_title,menu_title,parent,template,target,position,visibility,searching,menu,language,admin_groups,viewing_groups,modified_when,modified_by) VALUES ('$title','$title','$parent','$template','_top','$position','$visibility','1','1','$language','$admin_groups','$viewing_groups','".time()."','".$admin->get_user_id()."')";
$database->query($query);
if($database->is_error()) {
$admin->print_error($database->get_error());
}

Can I suggest that instead of always inserting "1" for the menu, can this be modified to insert the parent link menu value.

For a multi-menu template it is annoying to have to reset the new page to the correct menu when the value is already known.

Suggested mod...

Code:
// Work-out if the page parent (if selected) has a seperate template or language to the default
$query_parent = $database->query("SELECT template, language, menu FROM ".TABLE_PREFIX."pages WHERE page_id = '$parent'");
if($query_parent->numRows() > 0) {
$fetch_parent = $query_parent->fetchRow();
$template = $fetch_parent['template'];
$language = $fetch_parent['language'];
$menu = $fetch_parent['menu'];               //GWB
} else {
$template = '';
$language = DEFAULT_LANGUAGE;
  $menu = 1;                                  //GWB
}

// Insert page into pages table
$query = "INSERT INTO ".TABLE_PREFIX."pages (page_title,menu_title,parent,template,target,position,visibility,searching,menu,language,admin_groups,viewing_groups,modified_when,modified_by) VALUES ('$title','$title','$parent','$template','_top','$position','$visibility','1','$menu','$language','$admin_groups','$viewing_groups','".time()."','".$admin->get_user_id()."')";
$database->query($query);
if($database->is_error()) {
$admin->print_error($database->get_error());
}
« Last Edit: May 18, 2010, 07:53:01 AM by PurpleEdge » Logged
crnogorac081
AddOn Development
*
Offline Offline

Posts: 1706



« Reply #1 on: May 18, 2010, 08:31:04 AM »

I find this very usable..
Logged

Wow, I coded something myself: PM Messanger Modul ,Searchbox with suggestions
pcwacht
AddOn Development
*
Offline Offline

Posts: 2859



WWW
« Reply #2 on: May 18, 2010, 10:09:06 AM »

Might I suggest adding the parents template as well, and maybe even parents visibility?

John
Logged

http://www.ictwacht.nl = Dutch ICT info
http://www.pcwacht.nl = My first
both still work in progress, since years.....
PurpleEdge

Offline Offline

Posts: 232



WWW
« Reply #3 on: May 18, 2010, 10:27:38 AM »

The parent template is already used in the sql statement, and visibility is a value on the form when creating the page, so I think they are both OK?
Logged
pcwacht
AddOn Development
*
Offline Offline

Posts: 2859



WWW
« Reply #4 on: May 18, 2010, 03:39:13 PM »

Hmm didn't see it, must have dirt im my eyes Tongue
but yes, they are there Wink

John
Logged

http://www.ictwacht.nl = Dutch ICT info
http://www.pcwacht.nl = My first
both still work in progress, since years.....
PurpleEdge

Offline Offline

Posts: 232



WWW
« Reply #5 on: May 19, 2010, 07:10:22 AM »

Is there a process to get this implemented in future releases?
Logged
erpe

Offline Offline

Posts: 2077


WWW
« Reply #6 on: May 19, 2010, 08:14:38 AM »

You can open a ticket and hope, that someone finds it useful............ wink
http://project.websitebaker2.org/newticket

rgds

erpe
Logged

PurpleEdge

Offline Offline

Posts: 232



WWW
« Reply #7 on: May 19, 2010, 08:35:47 AM »

Done, easier than modifying WB on every release!  smiley
Logged
Pages: [1]   Go Up
Print
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.16 | SMF © 2011, Simple Machines Valid XHTML 1.0! Valid CSS!