Bookmark Module: Modified version released (incl. adjusting layout)

[Woudloper]

Within this thread (where someone suggested some additional features for the bookmark module) I also made some suggestions, but the developer suggested that I should create my own version based upon the existing bookmark module.

As I really would like to have the following options for the bookmark module:

• Make is possible to describe something about the bookmark link;
• Make it possible to modify the actual layout on the frontend;

I modified the existing version and added these options. Most of the logic of the existing module is still the same. The only things that have been done are:

• Altered the bookmark link table;
  Added the aboutbm field to make it possible to describe something about the bookmark
• Altered the bookmark settings table;
  Added several fields so the layout could be modified.
• Changed the 'view.php' to work with the new additions;
• Changed the 'modify_settings.php' so the layout looks a bit nicer

If someone would like to try this out, be my guest. I have not added an update script, but this shouldn't be to hard. Maybe this modified version could be the new bookmark module, but that is up to Ryan or Bennie since the build and modified the other versions.

If someone has any questions about the modification please do not hesitate to ask me.

NEW Update (new version)!!!

In one of the posts down below you can find an updated version that is including default loop information, etc.

[attachment deleted because of being too old]

[Bennie_wijs]

I installed it on a clean wb and what I am missing is default settings:
There is default no loop configured at all.

People starting with WB will now think that this module does not work or will ask for help.

I think it better if you have standard a loop configured so that you have a working bookmark.
Also its easier to create a new loop as well (Because you know the field names and stuff from the standard settings)

[wwwMARKLEYcouk]

i was just about to post the same thing. Also there is no default "bookmarks" folder created in the media section and its asking for it. None of my links are working and i do not know the code needed to make them visable

[Woudloper]

Yesterday evening I thought about that I forgot to add a default loop. Attached you will find a new version that includes the default loop.

Sorry about the earlier version which was wrong 

[attachment deleted because of being too old]

[ruebenwurzel]

@woudlouper

tested your last modified bookmarks and done some minor changes ( sorry but good is not good enough for me  )

• make admin interface multilangual (changed modify_settings.php and language.php)
• minor layout change in modify_link.php (line 106 + 115)
• minor issue in add.php (changed BMLINK1 to BMLINK and delete BMLINK2, BMLINK3, BMLINK4)
• created new upgrade_script wich updates from 2.3 to 2.3.1 modified3

Please test it

Matthias

Forgot: If no one needs the footer (column and in modify settings) then it should be deleted

Update

New Version released look in one of the posts down.

[i2Paq]

Wauw, one day I'm gone and so much has changed 

I will test Matthias one later today when I'm home (if that's ok @ Woudloper).

[wwwMARKLEYcouk]

i have installed the v3 of this module (which is now working ) but i have found a couple small issues.

• I have added a link entitled "Mystic's DVDs" and once the link is created it is generated with a "\" and shows up as "Mystic\'s DVDs". This happens in both the admin area and more importantly, on the actual site
• The "bookmarks" folder does not get created in the media directory
• If you cancel the creation of a link a blank one is still created.
• The image does not get resized to a default icon size (is there some code i can add to do this?)

sorry to be a pest, just trying to make things right 

[Woudloper]

@ i2Paq: That's fine with me. The bookmark module is more or less a group project where multiple people worked on. Maybe we also need to create a help section, just as I have done for the flickr.com Image Gallery module....

@ mysticfreeman: I have fixed your first point, since this was introduced by my enhancement of the bookmark module. There was a problem in the 'view.php' document where I forgot to add 'stripslashes' for 4 lines within the code. Atached you will find the new version.

The other 3 points where already in the existing version of the bookmark module, but I agree those should also be fixed. If I have some more time I will look into this, other people can also look into this as I don't have mutch time at the moment.

There is also another point. Maybe ruebenwurzel can fix this since he also did the other thing related to the language.

• When creating a new group, the button text (for the group) mentions 'Save link'. This should be 'save group'.

[attachment deleted because of being too old]

[ruebenwurzel]

@woudloper

There is also another point. Maybe ruebenwurzel can fix this since he also did the other thing related to the language.

• When creating a new group, the button text (for the group) mentions 'Save link'. This should be 'save group'.

Fixed 

Have Fun

Matthias

Update

New Version released look in one of the posts down.

[Woudloper]

@ ruebenwurzel: I see you have changed the download link, but I don't know what has been changed... I have downloaded the first version with was in your last reply...

I have modified the version and added the following:

• Fixed quote section within the 'modify.php' file, since the problem as described my mysticfreeman was also occuring over there
• Added a help section with some explenation

See attached new version. Hope you can enjoy this version and maybe extend and fix some stuff I have written in the help, etc... I will see the question/suggestions over here when I am back...

[attachment deleted because of being too old]

[ruebenwurzel]

@woudloper

Sorry for not posting the changes. There were only two minor changes in modify_link.php (line 100) and modify_group.php (Line 79).

• Fixed: Chancel button in Modify Groups redirects to a wrong page
• Modified: Changed Field in Modify Link for to use with language.php from Modul

added this changes to your modified6 Version and released modified7 version

Will have a look at your Help file tonight, but what I've seen yet is great 

Matthias

Update

New Version released look in one of the posts down.

[Woudloper]

Great, will have the modified7 for a try. If you will take a look at the help.php and if some other people (like: Benny, Mystic) will test if this version can be released as a 2.4.0 version of the bookmark module if you ask me...

[ruebenwurzel]

@woudloper
have changed the code in view.php wich causes wrong html-output. Now all seems to work ok. Also the Help file is a great idea. I'm according to you that a 2.4.0 version could be released. In th attachement you find the 2.4.0 RC1.

Have fun

Matthias

Update

New Version released look in one of the posts down.

[Woudloper]

@ ruebenwurzel: It looks nice and the output is correct now! The only thing that needs to be done is  to adjust the help about the target. Which code will be rendered when the [BMTARGET] will be inserted.

Furthermore it looks very nice. Did you also updated the changelog on the help page?

[ruebenwurzel]

@woudloper

ok, done a new look at the "target". Changed in modify_link.php target="_top" to target="_self" and modified help.php. Added a "Back" Button to the Helpfile (I think is better then the "settings" link at the top). Fixed a bug in the upgrade script ( There are no need for blank rows in the database when the modul only would be upgraded).

Matthias

Update

New Version released look in one of the posts down.

[Woudloper]

I have seen that I am not the only one who downloaded the module, but don't see any other response to the module. Hopefully some people will also post their comment about the new features of 2.4.0. as this can always be usefull for further releases.

The module looks very nice. Also the change you made for the 'target'. I have not tested the upgrade script, since I didn't worked with an older version. Maybe there is one point before we can make it final. Shouldn't the copyright statement (at the top of each page, inside the code) be changed. Now there is still a copyright statement of 'websitebaker' and not mentioning anything about the module and under which license the module is being shipped...

[Hans]

I have seen that I am not the only one who downloaded the module, but don't see any other response to the module. Hopefully some people will also post their comment about the new features of 2.4.0. as this can always be usefull for further releases.

I can only speak for myself, but being a total noob I always prefer to wait until most of the problems have gone. I'm not capable to contribute something to the development and I think there are many more users who are eager to use the modules but want to wait until it's "safe' to use them.
Anyways, I appreciate the effort of so many people here at the forums to make WB better. Thanks to all of them.

(I think I gonna try the module now, there isn't much that can go wrong anymore now . If there is something worth mentioning I will certainly come back here)
Thanks again.
Hans

[ruebenwurzel]

@woudloper
Yes, to change copyrights was the last point on my list too. Could you please do this, because this week I have a lot to do and not so much time.  All seems to work very fine now, so the modul could be released.

@the rest of the community
Please feel free to test this modul, would be nice to get some response about the new features and maybe failures we've overseen.

To upgrade an existing version of bookmarks, copy all files to your bookmarks directory, be sure all existing files are overwritten, and run once the upgrade-script (.../modules/bookmarks/upgrade_bookmarks.php).

Look in your admin Interface for the new features. The default dir for pics is media/bookmarks. This dir should be created in media section manually or choose another dir where your bookmarks pics are, otherwise you got an Error in the Edit link Page.

Have Fun

Matthias

[Hans]

Thanks Woudloper and Ruebenwurzel, everything works fine (RC2) and it is an easy to use bulletproof script.
The only thing I didn't like was a border around the images, but fixing that was easy enough with image {border: 0px;} under Header in the Layout settings. Great addition to the Modules.
Hans

[Woudloper]

Good to see everything is working as is should be. I think the suggestion is great and maybe should be added to the stylesheet in the 'header' of the bookmark module.

I've looked into the script again and walked through the code, but could not find any problem anymore, other then earlier mentioned (like: blank bookmarks), but those where already in the older version. Someone should in the future take a look at this, but I don't think this issue will be blocking for the 2.4.0. release of this module...

[Hans]

I aggree Woudloper, it's good as it is and a lot of users will use it this way.
Hans

[Woudloper]

@ ruebenwurzel: The suggestion you made last. The one about multi language files inside a module and use the WB language selection would be great.

I thought about it as followed. Add a subdirectory and put the language files (EN, DE, NL, etc.) and use that (selected language) specific file based upon the settings within the admin console...

Although it is a nice feature, I would suggest to not add this to the 2.4.0. Final release, but wait with this feature for a future release of the bookmark module.

[ruebenwurzel]

@woudloper
Yes, i agree to you that this way of multilanguage Files should be an Idea for future releases of all modules, not only the bookmarkmodul. Bookmark Modul 2.4.0 should be released as it is now.

Matthias

[Argos]

Is there any demo of this thing?

[Bennie_wijs]

Oke,

This version is looking good.

The bookmarks_v2.4.0 RC2.zip is renamed to bookmarks_v2.4.0.zi p and placed in the completed modules list.

Good work Woudloper and ruebenwurzel 

Argos: Example link