addon (2.6.0): Template Edit

[skidrash]

Looks good to me!  I will update it in the 'completed modules'.  Thank you for adding your time to this Matthias!

[jschor]

I installed the template edit (wb 2.6.1). Everything looks ok but when i try to change something i get the message succesfully saved, but when i look again nothing has been saved. Any ideas?

[ruebenwurzel]

What permissions have you on your template dir? The dir and all files should have chmod 777.

Matthias

[jschor]

changed the permissions of round template dir, index.php, info.php, screen.css en print.css to 777 and it works! But..... how should i know this. Wouldn't it be good to have a small readme file with the most important things to know about the installation of a module (especially for the ones in the completed module section but also the other modules) so people don't have to search this in the forum. This document can be updated according to the items that come up in the forum. It can also contain mod's on a module. I think this will result in less questions in the forum.

Bye the way thanks for your quick reply.

[ruebenwurzel]

Hmmm,

maybe an good idea to add to every module an included helpfile. Wouldloper did this already for some modules. So you have in the admin interface an help buttom where you get more informations about the modules.

Okay, will be in the next release.

Matthias

[skidrash]

I came accross a bug in template edit 1.3 that made it so you couldn't have \'s in your files.  I noticed it because I needed to use a '\n', and every time I saved it I ended up with just 'n'.  I also made the template listing a little more understandable when the template contains subfolders.  So here is an update:

Revision history:
1.4   Fixed \ removal bug, so now you can save \n in your code.
   Fixed template and file listing when template contains a subfolder
   Fixed English spelling error

This is also updated in the 'Completed Modules' thread.

[1.4 removed due to errors]

[ruebenwurzel]

Hello,

where is the option with ziping the template?

Matthias

[skidrash]

Under each template heading there is a list of files.  The first file in that list is a .zip file.  Simply select that file and hit continue.

[ruebenwurzel]

Hello,

this was the case in version 1.3, in version 1.4 the heading and the zip entry fails.

Matthias

[ruebenwurzel]

Hello,

also version 1.4 breaks my whole templates when i have edit them. There are now everywhere "\". Tested this on different installations. So please have a new look at this, and before releasing a new version at completed modules, maybe it is better to release RC's here for testing.

I would like you change back to v 1.3 at completed modules and let us discuss the v 1.4 here, make it together bugfree and then (when its completed) you can release it at completed modules.

Matthias

[skidrash]

Shoot, I'm sorry.  I figured it was a trivial update, so no sense in RC's.  Thats what I get for assuming.  Anyways, my bugged 1.4 has been removed, and 1.3 is back.  Basically the changes I made that appear to be causing the problems are these:

Added blockquote in the tool.ph p file to differentiate between headings and selectable files.  It's not that big of a deal to remove it, I just thought it would clean up the formatting. (I tried to make the files selectable via a drop-down box but I had way too many problems with that and just reverted to the original code)

Removed the stripslashes in the tool_save.ph p to allow for saving \n.  This is obviously why you are getting a bunch of \'s in your templates, and I really hope that didn't cause you too much trouble(I'm very sorry).  I don't understand why this operates differently for us.  Without the 'stripslashes' my templates save with no problems at all.  It retains any \n's that I've coded, and it displays perfectly in Firefox and IE.  With the 'stripslashes' (in 1.3) were you able to save templates with a \n?

I don't know if it has a bearing on how php executes, but my server is Windows2003 with IIS.  I know many people here use Linux and apache, but I had the understanding that php is php.  I'm running 4.4.1

Here is the module again but as an RC...

[skidrash]

Alright I did some work on the buggy 1.4rc1, and I need some testers...? 

The title and zip option for each template should show up for everyone now.  Please let me know if they don't.

At the bottom of the main template edit page(listing templates) there is a readout of whether or not your Magic Quotes are turned on(this is debug code for convenience)...

I added a check for Magic Quotes that  should allow it to save correctly with or without \'s.  I need someone with MQ's on and someone with MQ's off to test it and see if it works.  How to test it?  Open a test template and add a '\n' somewhere in the code, than save the file.  Open it again.  Does it have tons of \'s in it?  Is the \ still in the '\n' you added?

Any other problems?  Thanks!

[pcwacht]

For the magic quote slashes stuff,
have a look at wb build in functions:
/framework/class_wb.php
line 76 :    function add_slashes($input) {
line 85:   function strip_slashes($input) {
line 94:   function escape_backslashes($input) {

Using these makes coding much easier

John

[skidrash]

Wow, that would have been a lot easier.  haha  Looks like that strip_slashes() would have saved me some time.  As it is I'll see what kind of feedback I get with this build...  If I have to change something I'll use those functions.  Heres a stupid questions for you though...  If I were to use those functions, would I have include class_wb.php? (I'm still a little green at php)  Thanks!

[pcwacht]

trial and error is a sure way to try

The wb class is allready loaded (and some other classes as well)

John

[ruebenwurzel]

@skidrash

Have testet your RC2 with magic quotes = ON and all seems to work very fine. Added '\n' to my index.php and saved the file. No tons of '\' and the '\n' is still there where it should be.

Changed the following things and made the RC3 wich you finde attached:
1. Made your magic quotes test multilangual
2. Replaced all "Abbort" with "Abort"
3. Minor changes in the german language file

But is the magic quotes test necessary, or could you change the code so it works with magic quotes of and on?

Matthias

[skidrash]

I'm very sorry for taking so long to get back to this.  I had an emergency I had to attend too.  Anyways, Matthias, thank for trying out that \ test.  The code does work, whether magic quotes is turned on or off.  That was the problem before...  It only worked correctly with MQ turned on.  I tested RC2 with MQ's turned off, and you tested it with it on and they both worked correctly.  Basically I fixed the code to check the status of MQs, and save the file accordingly.  The magic quotes test is necessary for templateedit to support both situations, but it is my intention to remove the visible dubug info ("The status of your Magic Quotes PHP setting is: xx") on the final 1.4 version.

So basically it will just work, without you having to know if your MQs are on or off.

Thanks for the language file updates.  I will clean up my code and post the completed 1.4 both here and in the "completed modules" thread later tonight or tomorrow (unless you or anyone else sees something else that needs to be fixed?).  I'm going to post it as version 1.4a so that anyone who downloaded the earlier bugged 1.4 can differentiate. (anyone who installed the RC's will have to uninstall 1.4rcX in order to install 1.4a, otherwise it will say "already installed")

[skidrash]

Alright, I posted 1.4a in the completed modules. 

Template Edit

[thor1968]

Hello i'm still new to WB,

How do I actually install the templateedit module into wb, through FTP I guess... and where?

thanks a lot!

I still quite helpless sometimes...

[kweitzel]

Hi hor,

it is easier, than you think ... first download the zip file to your desktop (no matter what OS you have!). Then in the admin section, go to "add-ons" - "modules". There you find in the first line an install filed. Click on browse, select the zip-file you just downloaded and hit "install" ... that is all you need to do. The rest is managed by WB.

cheers

Klaus

[thor1968]

Thanks a lot!!!  sorry, I was away skiing this week... but now I did it! It works!!!

cheers!!!

[kweitzel]

no bother .. hope you didn't break any bones and enjoyed skiing ...

cheers
Klaus

[nepo77]

Hello!

Ive installed Tpl edit successfully ,and it shows all the templates files and i can chosse from them without a problem. My Problem is however that when i actually make a change to a template file the changes are not saved. It sais saved File round/index.php successfully, but it actually doesnt. Ive check file permissions and they are set to chmod 777. Any Ideas ?

Thanks for any help.
Greetings
Nepo77

[ruebenwurzel]

Hello,

Look not only to the permissions of the template dir, also look at the permissions of the Round template Folder. Should be chmod 777 too.

If Round template Folder and the round template files hav chmod 777 you maybe run into this problem:

Round Template is a standard Template from WB. It is uploaded per ftp with your WB Files. So it has the wrights of the ftp user. When you use the template edit modul you have the rights of the webserver. Webserver user normally could not change files wich owns the ftpuser. I think you also have problems to save changed files from AllCss, Simple and Blank Template.

If this is the case, here a little workaround:
1. Make with template edit a zip file from Round Template
2. Uninstall Round Template
3. Install Round Template from the zip File you created at point 1

This way the template is installed with webserver permissions and could be edit from template edit.

Hope this helps

Matthias

[nepo77]

Hello Ruebenwuerzel,

You were right, the round template had differnt settings than the uploaded ones via admin interface, i set them to 777 too and now it works.

Thanks alot for your super fast responce!

Greetingings
Nepo77