Code_2 Module

[erpe]

Hi@all

Aldus improved Chio's Code_2 Module and made it extensible.

New release can be downloaded at AMASP

rgds

erpe

[dbs]

very very nice modification!!!
good job, aldus! 

gruß dbs

[kirk]

Thank you for this nice extension.

where i can change the default setting full to smart?

i wanted the smart modus generelly.

Kirk

[aldus]

Inside "modify.php" line 37 - change "1" to "2" will do the trick:

Code:

<?php // as often - please ignore this line. 
$mode = ($whatis >= 10) ? (int)($whatis / 10) : 2;

Regards
Aldus

[roedental]

Hey, nice work!

I changed some comments to admin comment, how can I change it back?

Sven

[aldus]

Hm ... as far as i understand the moduldescription

"Admin Comment" can be edited only by admins (group 0), others see a yellow area in the backend.

you must be loged in as an admin ... otherwise you can't change it.

Regards
Aldus

[kirk]

aldus: thanks this mess up my backend

great

kirk

[roedental]

Hm ... as far as i understand the moduldescription
Quote
"Admin Comment" can be edited only by admins (group 0), others see a yellow area in the backend.

you must be loged in as an admin ... otherwise you can't change it.

I´m loged in with rights of an admin, but not as admin! I was able to change the comments to admin comments, but now I`m not able to change it back!

[aldus]

I haven't change the way the modul handles this situation ...
so far i can see it, you will make changes in the db via PhpMyAdmin in the
modul-table "mod_code2" and set the values of the "whatis" field to "0" (null) ...

Or use a codepage/dorplet to submit a query that will do the job.

Code:

<?php
$q = "update ".TABLE_PREFIX."mod_code2 set whatis=0 where whatis=4";
$r = $database->query( $q );
if ($database->is_error()) echo "Error: ".$database->get_error();
else echo "ok";
?>

Lefthanded untested!
Regards
Aldus

[aldus]

Chio has found a bug inside the upgrade.php and a nice suggestion for the view.php also,

Version 1.2.3 is at AMASP avaible:

http://www.websitebakers.com/pages/admin/core-replacements/code-2.php

Regards
Aldus

[roedental]

I haven't change the way the modul handles this situation ...
so far i can see it, you will make changes in the db via PhpMyAdmin in the
modul-table "mod_code2" and set the values of the "whatis" field to "0" (null) ...

That is OK, so I will change it in the db, but maybe it is possible to change the code of the module so, that every user, who has the admin rights, can change the comments back.

I have another wish, when  I use the admincomment, every other user sees only the comment, it would be nice, if the comment is a little bit more highlighted, so that erveryone recognize it.
Thanks for your work

Sven

[aldus]

Hm ... as far as i can read

Code:

<?php
if ($whatis == 4 AND $admin->get_group_id() <> 1) {
    $content = $content['content'];
    echo '<div class="code2_admin">'.$content.'</div>';
} else {
?>

You must belong to the group(_id) 1 (Admins) ... then it works ...

Hm ... another one is the language-support - still in englisch hardcoded,
so were is no dutch, german, france version avaible.

As for the colours - you can modify the backend.css as you like it ...

Still something to do on this little modul ... 

Regards
Aldus

[aldus]

Version 1.2.4 is uploaded to AMASP
http://www.websitebakers.com/pages/admin/core-replacements/code-2.php

Add languagesupport for EN and DE ... could be nice to have also an NL/FR version in future.
There are additional language-strings inside the "backend.js" to modify for new languages,
but mostly is inside the language files. Also some minor cosmetic changes to get rid of the
//dancing// mode-select if the type is changing ...

Regards
Aldus

[roedental]

Hey,

I changed the code like this:

$admin = $_SESSION['GROUPS_ID'];

if ($whatis == 4 AND $admin != 1) {
    $content = $content['content'];
    echo '<div class="code2_admin">'.$content.'</div>';
} else {
    $content = (htmlspecialchars($content['content']));
// none admin
if  ($admin != 1) {
        $whatisarray = array('PHP', 'HTML', 'Javascript', 'Internal Comment');
                 }
// admin
if ($admin == 1) {
    $whatisarray = array('PHP', 'HTML', 'Javascript', 'Internal Comment', 'Admin Comment');
                  }
   

Now it works for me. I use the groups_id, not the group_id, because all users with admin rights are in the same groups_id. And only for users with admin right is it possible to use the the admincomment,other users have only the choice between PHP, HTML, JAVASCRIPT and INTERNAL COMMENT!

See you
Sven

[thorn]

Hello,

$admin = $_SESSION['GROUPS_ID'];

($admin is reserved for use with wb classes, as $wb, too. Do not use $admin for other purposes!)
afaik, groups_id is an array EDIT: a comma separated string (to hold more than one group a user may belongs to).

So something like

Code:

$groups = $_SESSION['GROUPS_ID'];
$groups = explode(',', $groups);
...
if ($whatis == 4 AND in_array(1, $groups)) {

is needed.

Or better

Code:

$groups = $admin->get_groups_id();
...
if ($whatis == 4 AND in_array(1, $groups)) {

thorn.

[roedental]

Thanks, I will do it better next time!

[roedental]

Hey Aldus,

I like the Admin comment to give other users some hints, but I have some users, who have no rights for the modules, they only can write and edit news. But such users don`t see my hints, because they have no rights for modules. Is it possible, that every user can see the admin comments?

Thanks for your work!

Sven

[aldus]

Hm ... maybe i missunderstood, but you can set the rights
to see/edit modules in the advanced-settings of "groups" -> "modul permissions" ...
Maybe this is what you want ...

Regards
Aldus

[roedental]

Yes, I know this, but then the Users can see and edit  all Code2 sections. I want, that this users can see only the admin comments and not the other code2 sections. They should not work with the Code2 module, they should only see the admin comments.

Sven

[Stefek]

Hi,

I get a ERROR while installing the latest Version (fresh from Amasp)


Notice: Undefined variable: js_back in /www/htdocs/w0098-0815/mydemo/modules/code2/install.php on line 77

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '\'0\',`page_id` INT NOT NULL DEFAULT \'0\',`whatis` INT NOT NULL DEFAULT \'0\',`' at line 1


Running on a subdomain by all-inkl.com

Any suggestions?

Regards,
Stefek

[aldus]

Hi,

I get a ERROR while installing the latest Version (fresh from Amasp)


Notice: Undefined variable: js_back in /www/htdocs/w0098-0815/mydemo/modules/code2/install.php on line 77

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '\'0\',`page_id` INT NOT NULL DEFAULT \'0\',`whatis` INT NOT NULL DEFAULT \'0\',`' at line 1


Running on a subdomain by all-inkl.com

Any suggestions?

Regards,
Stefek

Hello Stefek

Could be the mySql version - could be the php version - could be ...

however ... i've attache a 'hotfix' (2.0.1.1) and want to know if it works ...

Regards
Aldus

[Stefek]

Hi Aldus,

Installation was good now, but after generating a new section code2
I get this message:


Parse error: syntax error, unexpected T_STRING, expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in /www/htdocs/w0815/mydemo/modules/code2/classes/c_js_loader.php on line 7

[aldus]

Do you run under PHP4 or PHP5 ... if so ... try the php5-httacccess hack ... as the class for the quick hack was for ... ups
PHP5!
Maybe i got an php4 - version this evening ... but better wait for tomorrow ..

Regards
Aldus
... immer grüsst das murmeltier ... ausgerechnet vor meiner Tür ...

Edit
Die php4 version als 2.0.1.2 als Attachment ... sollte so eigentlich funktionieren

WB rocks 

[Stefek]

Thanks Aldus.

Works great now on PHP 4.4.9


Regards,
Stefek

[instantflorian]

Hi,

is it possible to use EditArea for this module? Syntax highlighting in the backende of a code2 section would be quite useful...

Regards

-instantflorian.