John,
thanks for your contribution. Have reviewed the template and found some issues which should be fixed before the template will be added to the addons repository.
The
general comment block in text files should provide the purpose of the individual file and some information about author, not the text from the master template.
The variable
$template_directory have not to contain any characters other than: a-z, _ and - in lower case (no spaces, no uppercase etc. are allowed here).
The variable
$template_license in info.php should provide a link to the license like:
$template_license = '<a href="
http://creativecommons.org/licenses/by/2.5/">Creative Commons Attribution license</a>';
Currently the license terms are not very clear to me. In the comment blocks you state: Original Design by
Cvrk/Modified for WebSite Baker ...". In $template_license_terms you state: "The author kindly asks to leave a link back to
Erwin Aligam site." Who is the original author of the template? Cvrk or Erwin Aligman. If it is Erwin, please change the license from GNU to
CC 2.5 chosen by Erwin. We had some issues in the past with licenses and we need to take this part serious. If you would like a contribution to your site, feel free to add a link to your website in the footer and add something like: "Credits in footer must remain intact as per the licence - the designer and the porter sections."
Please find attached a modified version with the applied fixes (license as defined by yourself, please correct if required). Have not tested browser compatibility or validity of HTML/CSS yet. Please feel free to review and modify the changes I made.
Regards Christian
[Edit]If the template is ported from an existing template, use the following line in info.php:
$template_author = 'Erwin Aligam; John P., Charles M. (WB port)';
The code for optional template functions like frontend search (login etc.) should be taken over from the template guidelines. The search uses PAGE_EXTENSION for /search/index.php which should be avoided as this is a WB core file and hence not influenced by user settings.
<form class="search" action="<?php echo WB_URL.'/search/index'.PAGE_EXTENSION; ?>" method="post">
WebsiteBaker Community Forum
